test(linter/plugins): align ESLint plugin with Oxlint #14059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Aligns ESLint plugin naming with Oxlint configuration by changing the plugin name from "testPlugin" to "define-rule-plugin" in test fixtures for better comparison between the two linting tools.
- Changed plugin name from "testPlugin" to "define-rule-plugin" in ESLint configuration
- Updated corresponding rule references to use the new plugin name
- Updated test snapshots to reflect the new plugin naming
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/test/fixtures/define/eslint.config.js | Updated plugin name and rule references from "testPlugin" to "define-rule-plugin" |
| apps/oxlint/test/snapshots/eslint-compat.test.ts.snap | Updated test snapshots to reflect the new plugin naming in error messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
Merge activity
|
Minor refactor of tests. Name the plugin the same in ESLint config as Oxlint config, for easier comparison of the 2.
graphite-app
bot
force-pushed
the
09-23-test_linter_plugins_align_eslint_plugin_with_oxlint
branch
from
b5f84df to
b109419
Compare
graphite-app
bot
deleted the
09-23-test_linter_plugins_align_eslint_plugin_with_oxlint
branch
This was referenced Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactor of tests. Name the plugin the same in ESLint config as Oxlint config, for easier comparison of the 2.