Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Sep 25, 2025

This is to avoid printing comments in the wrong places.

Copy link
Member Author

Dunqing commented Sep 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Sep 25, 2025
@Dunqing Dunqing force-pushed the 09-25-fix_formatter_print_comments_incorrectly_if_the_node_is_without_following_a_node branch from 40a9cfa to 6d37ce6 Compare September 25, 2025 07:52
@Dunqing Dunqing force-pushed the 09-25-fix_formatter_merge_the_right_side_of_logicalexpression_if_it_s_a_logicalexpression_and_both_have_the_same_operator branch from 20ecffb to a044f67 Compare September 25, 2025 07:52
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 25, 2025

CodSpeed Instrumentation Performance Report

Merging #14110 will not alter performance

Comparing 09-25-fix_formatter_print_comments_incorrectly_if_the_node_is_without_following_a_node (7c09b20) with main (ed33fad)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing marked this pull request as ready for review September 26, 2025 12:04
@Dunqing Dunqing force-pushed the 09-25-fix_formatter_print_comments_incorrectly_if_the_node_is_without_following_a_node branch from 6d37ce6 to 54c4ed1 Compare September 26, 2025 16:42
@Dunqing Dunqing force-pushed the 09-25-fix_formatter_merge_the_right_side_of_logicalexpression_if_it_s_a_logicalexpression_and_both_have_the_same_operator branch from a044f67 to 7cad4d7 Compare September 26, 2025 16:42
@Dunqing Dunqing requested a review from leaysgur September 29, 2025 08:59
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Sep 29, 2025
Copy link
Member

leaysgur commented Sep 29, 2025

Merge activity

  • Sep 29, 9:37 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 29, 9:42 AM UTC: leaysgur added this pull request to the Graphite merge queue.
  • Sep 29, 9:53 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14083.
  • Sep 29, 9:53 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14083.
  • Sep 29, 1:43 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 29, 1:44 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Sep 29, 1:50 PM UTC: leaysgur added this pull request to the Graphite merge queue.
  • Sep 29, 1:56 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 29, 2025
@graphite-app graphite-app bot force-pushed the 09-25-fix_formatter_merge_the_right_side_of_logicalexpression_if_it_s_a_logicalexpression_and_both_have_the_same_operator branch from 7cad4d7 to acc4f32 Compare September 29, 2025 13:00
@graphite-app graphite-app bot force-pushed the 09-25-fix_formatter_merge_the_right_side_of_logicalexpression_if_it_s_a_logicalexpression_and_both_have_the_same_operator branch 2 times, most recently from 6792579 to 9976dde Compare September 29, 2025 13:24
@graphite-app graphite-app bot changed the base branch from 09-25-fix_formatter_merge_the_right_side_of_logicalexpression_if_it_s_a_logicalexpression_and_both_have_the_same_operator to graphite-base/14110 September 29, 2025 13:37
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Sep 29, 2025
@leaysgur leaysgur force-pushed the 09-25-fix_formatter_print_comments_incorrectly_if_the_node_is_without_following_a_node branch from 54c4ed1 to c387a35 Compare September 29, 2025 13:44
@graphite-app graphite-app bot changed the base branch from graphite-base/14110 to main September 29, 2025 13:44
…lowing a node (#14110)

This is to avoid printing comments in the wrong places.
@graphite-app graphite-app bot force-pushed the 09-25-fix_formatter_print_comments_incorrectly_if_the_node_is_without_following_a_node branch from c387a35 to 7c09b20 Compare September 29, 2025 13:50
@graphite-app graphite-app bot merged commit 7c09b20 into main Sep 29, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 09-25-fix_formatter_print_comments_incorrectly_if_the_node_is_without_following_a_node branch September 29, 2025 13:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 29, 2025
@Boshen Boshen mentioned this pull request Oct 9, 2025
graphite-app bot pushed a commit that referenced this pull request Oct 14, 2025
Benefits from the changes of #14110, we don't need to print all remaining comments before `}` in import and export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants