Skip to content

test(linter/plugins): improve ESLint compat tests #14119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

test(linter/plugins): improve ESLint compat tests #14119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions apps/oxlint/test/fixtures/definePlugin/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { sep } from 'node:path';
import { definePlugin } from '../../../dist/index.js';

// `loc` field is required for ESLint.
// TODO: Remove this workaround when AST nodes have a `loc` field.
// `loc` is required for ESLint
const SPAN = {
start: 0,
end: 0,
Expand All @@ -26,7 +25,7 @@ const createRule = {
Identifier(node) {
context.report({
message: `ident visit fn "${node.name}":\nfilename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
};
Expand Down Expand Up @@ -72,7 +71,7 @@ const createOnceRule = {
message: `ident visit fn "${node.name}":\n`
+ `identNum: ${identNum}\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
after() {
Expand Down Expand Up @@ -123,7 +122,7 @@ const createOnceBeforeFalseRule = {
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
after() {
Expand Down Expand Up @@ -153,7 +152,7 @@ const createOnceBeforeOnlyRule = {
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
};
Expand All @@ -167,7 +166,7 @@ const createOnceAfterOnlyRule = {
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
after() {
Expand All @@ -188,7 +187,7 @@ const createOnceNoHooksRule = {
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
};
Expand Down
15 changes: 7 additions & 8 deletions apps/oxlint/test/fixtures/definePlugin_and_defineRule/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { sep } from 'node:path';
import { definePlugin, defineRule } from '../../../dist/index.js';

// `loc` field is required for ESLint.
// TODO: Remove this workaround when AST nodes have a `loc` field.
// `loc` is required for ESLint
const SPAN = {
start: 0,
end: 0,
Expand All @@ -26,7 +25,7 @@ const createRule = defineRule({
Identifier(node) {
context.report({
message: `ident visit fn "${node.name}":\nfilename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
};
Expand Down Expand Up @@ -71,7 +70,7 @@ const createOnceRule = defineRule({
message: `ident visit fn "${node.name}":\n`
+ `identNum: ${identNum}\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
after() {
Expand Down Expand Up @@ -122,7 +121,7 @@ const createOnceBeforeFalseRule = defineRule({
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
after() {
Expand Down Expand Up @@ -152,7 +151,7 @@ const createOnceBeforeOnlyRule = defineRule({
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
};
Expand All @@ -166,7 +165,7 @@ const createOnceAfterOnlyRule = defineRule({
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
after() {
Expand All @@ -187,7 +186,7 @@ const createOnceNoHooksRule = defineRule({
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
};
Expand Down
15 changes: 7 additions & 8 deletions apps/oxlint/test/fixtures/defineRule/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { sep } from 'node:path';
import { defineRule } from '../../../dist/index.js';

// `loc` field is required for ESLint.
// TODO: Remove this workaround when AST nodes have a `loc` field.
// `loc` is required for ESLint
const SPAN = {
start: 0,
end: 0,
Expand All @@ -26,7 +25,7 @@ const createRule = defineRule({
Identifier(node) {
context.report({
message: `ident visit fn "${node.name}":\nfilename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
};
Expand Down Expand Up @@ -71,7 +70,7 @@ const createOnceRule = defineRule({
message: `ident visit fn "${node.name}":\n`
+ `identNum: ${identNum}\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
after() {
Expand Down Expand Up @@ -122,7 +121,7 @@ const createOnceBeforeFalseRule = defineRule({
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
after() {
Expand Down Expand Up @@ -152,7 +151,7 @@ const createOnceBeforeOnlyRule = defineRule({
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
};
Expand All @@ -166,7 +165,7 @@ const createOnceAfterOnlyRule = defineRule({
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
after() {
Expand All @@ -187,7 +186,7 @@ const createOnceNoHooksRule = defineRule({
context.report({
message: `ident visit fn "${node.name}":\n`
+ `filename: ${relativePath(context.filename)}`,
node: { ...SPAN, ...node },
node,
});
},
};
Expand Down
Loading