From a6f965f1a2fe8da1f2fdaf7b3ac3e975f1b5ffc0 Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Thu, 25 Sep 2025 20:35:48 +0000 Subject: [PATCH] test(linter/plugins): simplify configs in test fixtures (#14124) Pure refactor. Remove `"ignorePatterns": ["**/*", "!files/**"]` from `.oxlintrc.json` in every test fixture, by running `oxlint` with `oxlint --js-plugins files`. --- apps/oxlint/test/e2e.test.ts | 2 +- apps/oxlint/test/fixtures/basic_custom_plugin/.oxlintrc.json | 3 +-- .../fixtures/basic_custom_plugin_many_files/.oxlintrc.json | 3 +-- .../fixtures/basic_custom_plugin_multiple_rules/.oxlintrc.json | 3 +-- .../fixtures/basic_custom_plugin_warn_severity/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/built_in_errors/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/built_in_no_errors/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/context_properties/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/createOnce/.oxlintrc.json | 3 +-- .../fixtures/custom_plugin_disable_directives/.oxlintrc.json | 3 +-- .../test/fixtures/custom_plugin_import_error/.oxlintrc.json | 3 +-- .../custom_plugin_lint_after_hook_error/.oxlintrc.json | 3 +-- .../custom_plugin_lint_before_hook_error/.oxlintrc.json | 3 +-- .../custom_plugin_lint_createOnce_error/.oxlintrc.json | 3 +-- .../fixtures/custom_plugin_lint_create_error/.oxlintrc.json | 3 +-- .../test/fixtures/custom_plugin_lint_fix_error/.oxlintrc.json | 3 +-- .../fixtures/custom_plugin_lint_visit_error/.oxlintrc.json | 3 +-- .../test/fixtures/custom_plugin_missing_rule/.oxlintrc.json | 3 +-- .../test/fixtures/custom_plugin_via_overrides/.oxlintrc.json | 3 +-- .../custom_plugin_via_overrides_missing_rule/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/definePlugin/.oxlintrc.json | 3 +-- .../test/fixtures/definePlugin_and_defineRule/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/defineRule/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/estree/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/fixes/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/load_paths/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/missing_custom_plugin/.oxlintrc.json | 3 +-- apps/oxlint/test/fixtures/utf16_offsets/.oxlintrc.json | 3 +-- 28 files changed, 28 insertions(+), 55 deletions(-) diff --git a/apps/oxlint/test/e2e.test.ts b/apps/oxlint/test/e2e.test.ts index 80cb750641454..8e5a89f8d8193 100644 --- a/apps/oxlint/test/e2e.test.ts +++ b/apps/oxlint/test/e2e.test.ts @@ -28,7 +28,7 @@ async function testFixture(fixtureName: string, options?: TestOptions): Promise< await testFixtureWithCommand({ command: 'node', - args: [CLI_PATH, ...args], + args: [CLI_PATH, ...args, 'files'], fixtureName, snapshotName: options?.snapshotName ?? 'output', getExtraSnapshotData: options?.getExtraSnapshotData, diff --git a/apps/oxlint/test/fixtures/basic_custom_plugin/.oxlintrc.json b/apps/oxlint/test/fixtures/basic_custom_plugin/.oxlintrc.json index 3b4f1ab3b9067..e18c3a914be6c 100644 --- a/apps/oxlint/test/fixtures/basic_custom_plugin/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/basic_custom_plugin/.oxlintrc.json @@ -2,6 +2,5 @@ "plugins": ["./plugin.js"], "rules": { "basic-custom-plugin/no-debugger": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/basic_custom_plugin_many_files/.oxlintrc.json b/apps/oxlint/test/fixtures/basic_custom_plugin_many_files/.oxlintrc.json index 3b4f1ab3b9067..e18c3a914be6c 100644 --- a/apps/oxlint/test/fixtures/basic_custom_plugin_many_files/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/basic_custom_plugin_many_files/.oxlintrc.json @@ -2,6 +2,5 @@ "plugins": ["./plugin.js"], "rules": { "basic-custom-plugin/no-debugger": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/basic_custom_plugin_multiple_rules/.oxlintrc.json b/apps/oxlint/test/fixtures/basic_custom_plugin_multiple_rules/.oxlintrc.json index 4e386349a8b8a..584fe5212c27c 100644 --- a/apps/oxlint/test/fixtures/basic_custom_plugin_multiple_rules/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/basic_custom_plugin_multiple_rules/.oxlintrc.json @@ -4,6 +4,5 @@ "basic-custom-plugin/no-debugger": "error", "basic-custom-plugin/no-debugger-2": "error", "basic-custom-plugin/no-identifiers-named-foo": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/basic_custom_plugin_warn_severity/.oxlintrc.json b/apps/oxlint/test/fixtures/basic_custom_plugin_warn_severity/.oxlintrc.json index 2b0a6f1e20397..a4e9307ce5189 100644 --- a/apps/oxlint/test/fixtures/basic_custom_plugin_warn_severity/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/basic_custom_plugin_warn_severity/.oxlintrc.json @@ -2,6 +2,5 @@ "plugins": ["./plugin.js"], "rules": { "basic-custom-plugin/no-debugger": "warn" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/built_in_errors/.oxlintrc.json b/apps/oxlint/test/fixtures/built_in_errors/.oxlintrc.json index 79a17a710c5a9..91ec3d661a1c6 100644 --- a/apps/oxlint/test/fixtures/built_in_errors/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/built_in_errors/.oxlintrc.json @@ -1,5 +1,4 @@ { "categories": { "correctness": "off" }, - "rules": { "no-debugger": "error" }, - "ignorePatterns": ["**/*", "!files/**"] + "rules": { "no-debugger": "error" } } diff --git a/apps/oxlint/test/fixtures/built_in_no_errors/.oxlintrc.json b/apps/oxlint/test/fixtures/built_in_no_errors/.oxlintrc.json index 79a17a710c5a9..91ec3d661a1c6 100644 --- a/apps/oxlint/test/fixtures/built_in_no_errors/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/built_in_no_errors/.oxlintrc.json @@ -1,5 +1,4 @@ { "categories": { "correctness": "off" }, - "rules": { "no-debugger": "error" }, - "ignorePatterns": ["**/*", "!files/**"] + "rules": { "no-debugger": "error" } } diff --git a/apps/oxlint/test/fixtures/context_properties/.oxlintrc.json b/apps/oxlint/test/fixtures/context_properties/.oxlintrc.json index d380fe2996b7b..20f91d1399079 100644 --- a/apps/oxlint/test/fixtures/context_properties/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/context_properties/.oxlintrc.json @@ -3,6 +3,5 @@ "categories": {"correctness": "off"}, "rules": { "context-plugin/log-context": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/createOnce/.oxlintrc.json b/apps/oxlint/test/fixtures/createOnce/.oxlintrc.json index 298ddf688f102..c70f3ecfd4f8f 100644 --- a/apps/oxlint/test/fixtures/createOnce/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/createOnce/.oxlintrc.json @@ -7,6 +7,5 @@ "create-once-plugin/before-only": "error", "create-once-plugin/after-only": "error", "create-once-plugin/no-hooks": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/custom_plugin_disable_directives/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_disable_directives/.oxlintrc.json index 88158dea4c36a..50d7120bc2ac4 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_disable_directives/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_disable_directives/.oxlintrc.json @@ -4,6 +4,5 @@ "rules": { "test-plugin/no-var": "error", "no-debugger": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/custom_plugin_import_error/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_import_error/.oxlintrc.json index 63bddccedb381..899cae0e2cff6 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_import_error/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_import_error/.oxlintrc.json @@ -3,6 +3,5 @@ "categories": { "correctness": "off" }, "rules": { "basic-custom-plugin/unknown-rule": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/custom_plugin_lint_after_hook_error/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_lint_after_hook_error/.oxlintrc.json index b347ef444f0d3..e8d3a5ab0438a 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_lint_after_hook_error/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_lint_after_hook_error/.oxlintrc.json @@ -3,6 +3,5 @@ "categories": { "correctness": "off" }, "rules": { "error-plugin/error": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/custom_plugin_lint_before_hook_error/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_lint_before_hook_error/.oxlintrc.json index b347ef444f0d3..e8d3a5ab0438a 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_lint_before_hook_error/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_lint_before_hook_error/.oxlintrc.json @@ -3,6 +3,5 @@ "categories": { "correctness": "off" }, "rules": { "error-plugin/error": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/custom_plugin_lint_createOnce_error/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_lint_createOnce_error/.oxlintrc.json index b347ef444f0d3..e8d3a5ab0438a 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_lint_createOnce_error/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_lint_createOnce_error/.oxlintrc.json @@ -3,6 +3,5 @@ "categories": { "correctness": "off" }, "rules": { "error-plugin/error": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/custom_plugin_lint_create_error/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_lint_create_error/.oxlintrc.json index b347ef444f0d3..e8d3a5ab0438a 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_lint_create_error/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_lint_create_error/.oxlintrc.json @@ -3,6 +3,5 @@ "categories": { "correctness": "off" }, "rules": { "error-plugin/error": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/.oxlintrc.json index b347ef444f0d3..e8d3a5ab0438a 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_lint_fix_error/.oxlintrc.json @@ -3,6 +3,5 @@ "categories": { "correctness": "off" }, "rules": { "error-plugin/error": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/custom_plugin_lint_visit_error/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_lint_visit_error/.oxlintrc.json index b347ef444f0d3..e8d3a5ab0438a 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_lint_visit_error/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_lint_visit_error/.oxlintrc.json @@ -3,6 +3,5 @@ "categories": { "correctness": "off" }, "rules": { "error-plugin/error": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/custom_plugin_missing_rule/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_missing_rule/.oxlintrc.json index 63bddccedb381..899cae0e2cff6 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_missing_rule/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_missing_rule/.oxlintrc.json @@ -3,6 +3,5 @@ "categories": { "correctness": "off" }, "rules": { "basic-custom-plugin/unknown-rule": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/custom_plugin_via_overrides/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_via_overrides/.oxlintrc.json index e13213d771998..28a429cd5fdaa 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_via_overrides/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_via_overrides/.oxlintrc.json @@ -7,6 +7,5 @@ "basic-custom-plugin/no-debugger": "error" } } - ], - "ignorePatterns": ["**/*", "!files/**"] + ] } diff --git a/apps/oxlint/test/fixtures/custom_plugin_via_overrides_missing_rule/.oxlintrc.json b/apps/oxlint/test/fixtures/custom_plugin_via_overrides_missing_rule/.oxlintrc.json index 9bc96eeb03595..18acd6b1c4fd0 100644 --- a/apps/oxlint/test/fixtures/custom_plugin_via_overrides_missing_rule/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/custom_plugin_via_overrides_missing_rule/.oxlintrc.json @@ -10,6 +10,5 @@ "basic-custom-plugin/missing": "error" } } - ], - "ignorePatterns": ["**/*", "!files/**"] + ] } diff --git a/apps/oxlint/test/fixtures/definePlugin/.oxlintrc.json b/apps/oxlint/test/fixtures/definePlugin/.oxlintrc.json index 43db4a2b62d75..a1b15cc8a76ce 100644 --- a/apps/oxlint/test/fixtures/definePlugin/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/definePlugin/.oxlintrc.json @@ -8,6 +8,5 @@ "define-plugin-plugin/create-once-before-only": "error", "define-plugin-plugin/create-once-after-only": "error", "define-plugin-plugin/create-once-no-hooks": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/definePlugin_and_defineRule/.oxlintrc.json b/apps/oxlint/test/fixtures/definePlugin_and_defineRule/.oxlintrc.json index f8f626481f508..b7fba379f2626 100644 --- a/apps/oxlint/test/fixtures/definePlugin_and_defineRule/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/definePlugin_and_defineRule/.oxlintrc.json @@ -8,6 +8,5 @@ "define-plugin-and-rule-plugin/create-once-before-only": "error", "define-plugin-and-rule-plugin/create-once-after-only": "error", "define-plugin-and-rule-plugin/create-once-no-hooks": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/defineRule/.oxlintrc.json b/apps/oxlint/test/fixtures/defineRule/.oxlintrc.json index b592dfc21dbcf..2a67e9f62ac67 100644 --- a/apps/oxlint/test/fixtures/defineRule/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/defineRule/.oxlintrc.json @@ -8,6 +8,5 @@ "define-rule-plugin/create-once-before-only": "error", "define-rule-plugin/create-once-after-only": "error", "define-rule-plugin/create-once-no-hooks": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/estree/.oxlintrc.json b/apps/oxlint/test/fixtures/estree/.oxlintrc.json index 7ab18b1763b87..20ebf7d987da5 100644 --- a/apps/oxlint/test/fixtures/estree/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/estree/.oxlintrc.json @@ -5,6 +5,5 @@ }, "rules": { "estree-check/check": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/fixes/.oxlintrc.json b/apps/oxlint/test/fixtures/fixes/.oxlintrc.json index 21cc0822fd19c..ab11aa02bab2e 100644 --- a/apps/oxlint/test/fixtures/fixes/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/fixes/.oxlintrc.json @@ -5,6 +5,5 @@ }, "rules": { "fixes-plugin/fixes": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/load_paths/.oxlintrc.json b/apps/oxlint/test/fixtures/load_paths/.oxlintrc.json index 890063ee29356..1e68429a4d77f 100644 --- a/apps/oxlint/test/fixtures/load_paths/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/load_paths/.oxlintrc.json @@ -14,6 +14,5 @@ "plugin4/no-debugger": "error", "plugin5/no-debugger": "error", "plugin6/no-debugger": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } } diff --git a/apps/oxlint/test/fixtures/missing_custom_plugin/.oxlintrc.json b/apps/oxlint/test/fixtures/missing_custom_plugin/.oxlintrc.json index 09a1fc3997736..79b90b2af715f 100644 --- a/apps/oxlint/test/fixtures/missing_custom_plugin/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/missing_custom_plugin/.oxlintrc.json @@ -1,6 +1,5 @@ { "plugins": [ "./plugin.js" - ], - "ignorePatterns": ["**/*", "!files/**"] + ] } diff --git a/apps/oxlint/test/fixtures/utf16_offsets/.oxlintrc.json b/apps/oxlint/test/fixtures/utf16_offsets/.oxlintrc.json index f96789cf56fd9..0c79ae0c3a285 100644 --- a/apps/oxlint/test/fixtures/utf16_offsets/.oxlintrc.json +++ b/apps/oxlint/test/fixtures/utf16_offsets/.oxlintrc.json @@ -2,6 +2,5 @@ "plugins": ["./plugin.js"], "rules": { "utf16-plugin/no-debugger": "error" - }, - "ignorePatterns": ["**/*", "!files/**"] + } }