Skip to content

refactor(napi/parser): remove unnecessary #[estree(field_order)] attr #14144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

refactor(napi/parser): remove unnecessary #[estree(field_order)] attr #14144

merged 1 commit into from
Sep 26, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 26, 2025 •
edited
Loading

span is now automatically moved to be last field, so no need to specify field order explicitly here.

@github-actions github-actions bot added the A-parser Area - Parser label Sep 26, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Sep 26, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 26, 2025
This was referenced Sep 26, 2025
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review September 26, 2025 08:42
@overlookmotel overlookmotel changed the title refactor(napi/parser): remove unneccesary #[estree(field_order)] attr refactor(napi/parser): remove unnecessary #[estree(field_order)] attr Sep 26, 2025
@overlookmotel overlookmotel self-assigned this Sep 26, 2025
Boshen
Boshen reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could just be one PR ...

@graphite-app graphite-app bot force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch 2 times, most recently from a394e91 to 38caec5 Compare September 26, 2025 08:53
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 26, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Sep 26, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Sep 26, 9:00 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 26, 9:06 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 26, 9:06 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 26, 9:12 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14143.
  • Sep 26, 9:12 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14143.
  • Sep 26, 9:12 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 26, 9:13 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Sep 26, 9:35 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 26, 9:36 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 26, 9:36 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Sep 26, 9:40 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 26, 9:41 AM UTC: Merged by the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch from 38caec5 to dc6b90b Compare September 26, 2025 09:01
@overlookmotel overlookmotel force-pushed the 09-26-refactor_napi_parser_remove_unneccesary_estree_field_order_attr branch from 4dc5f69 to e8cc925 Compare September 26, 2025 09:01
@overlookmotel overlookmotel reopened this Sep 26, 2025
@overlookmotel overlookmotel added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Sep 26, 2025
@graphite-app graphite-app bot force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch from dc6b90b to ff24615 Compare September 26, 2025 09:09
@graphite-app graphite-app bot force-pushed the 09-26-refactor_napi_parser_remove_unneccesary_estree_field_order_attr branch from e8cc925 to 9d5f37b Compare September 26, 2025 09:09
graphite-app bot pushed a commit that referenced this pull request Sep 26, 2025
@overlookmotel
refactor(napi/parser): remove unnecessary #[estree(field_order)] at…
9d5f37b 
…tr (#14144)

`span` is now automatically moved to be last field, so no need to specify field order explicitly here.
@graphite-app graphite-app bot force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch from ff24615 to fd299aa Compare September 26, 2025 09:10
graphite-app bot pushed a commit that referenced this pull request Sep 26, 2025
@overlookmotel
refactor(napi/parser): remove unnecessary #[estree(field_order)] at…
2b61f50 
…tr (#14144)

`span` is now automatically moved to be last field, so no need to specify field order explicitly here.
@graphite-app graphite-app bot force-pushed the 09-26-refactor_napi_parser_remove_unneccesary_estree_field_order_attr branch from 9d5f37b to 2b61f50 Compare September 26, 2025 09:11
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 26, 2025
@overlookmotel
refactor(napi/parser): remove unnecessary #[estree(field_order)] at…
c0c0c17 
…tr (#14144)

`span` is now automatically moved to be last field, so no need to specify field order explicitly here.
@overlookmotel overlookmotel force-pushed the 09-26-refactor_napi_parser_remove_unneccesary_estree_field_order_attr branch from 2b61f50 to c0c0c17 Compare September 26, 2025 09:35
@overlookmotel overlookmotel force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch from fd299aa to 6fffdf9 Compare September 26, 2025 09:35
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 26, 2025
Base automatically changed from 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs to main September 26, 2025 09:40
@graphite-app graphite-app bot merged commit c0c0c17 into main Sep 26, 2025
23 of 34 checks passed
@graphite-app graphite-app bot deleted the 09-26-refactor_napi_parser_remove_unneccesary_estree_field_order_attr branch September 26, 2025 09:41
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 26, 2025
@Boshen Boshen mentioned this pull request Sep 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Boshen left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @Boshen