test(napi/parser): align fixture version with other tasks #14146
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the antd.js fixture version used in napi/parser tests and benchmarks to v4.16.1, matching the version already used in other Rust tasks as established in #13465. This resolves an issue where different tasks downloading fixtures to the same target directory could result in unpredictable behavior depending on execution order.
- Updated antd.js version from v5.12.5 to v4.16.1 in two fixture files
- Ensures consistent fixture versions across all tasks to prevent download conflicts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| napi/parser/test/parse-raw.test.ts | Updated antd.js fixture URL to use v4.16.1 instead of v5.12.5 |
| napi/parser/bench.bench.js | Updated antd.js fixture URL to use v4.16.1 instead of v5.12.5 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
graphite-app
bot
force-pushed
the
09-26-test_napi_parser_align_fixture_version_with_other_tasks
branch
from
471fdae to
aa17914
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
graphite-app
bot
force-pushed
the
09-26-test_napi_parser_align_fixture_version_with_other_tasks
branch
from
aa17914 to
088a403
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
graphite-app
bot
force-pushed
the
09-26-test_napi_parser_align_fixture_version_with_other_tasks
branch
from
088a403 to
f31df74
Compare
overlookmotel
added a commit
that referenced
this pull request
Sep 26, 2025
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
overlookmotel
force-pushed
the
09-26-test_napi_parser_align_fixture_version_with_other_tasks
branch
from
f31df74 to
6a51bd4
Compare
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
graphite-app
bot
force-pushed
the
09-26-test_napi_parser_align_fixture_version_with_other_tasks
branch
from
6a51bd4 to
8c09592
Compare
graphite-app
bot
deleted the
09-26-test_napi_parser_align_fixture_version_with_other_tasks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13465 aligned the version of
antd.jsused in different Rust tasks to v4.16.1. But it missed a couple of places innapi/parsertests/benchmarks. Align these to same version too.Misalignment was problematic as the tasks using these fixtures all download the file to same location (
targetdir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.