-
-
Notifications
You must be signed in to change notification settings - Fork 719
refactor(semantic): do not use Astnodes::get_node for check_unresolved_exports
#14176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(semantic): do not use Astnodes::get_node for check_unresolved_exports
#14176
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This refactoring removes the dependency on AstNodes::get_node for the check_unresolved_exports function by restructuring how unresolved exports are checked. The change moves from traversing unresolved references to directly iterating over AST nodes.
- Removes the
root()method fromUnresolvedReferencesStack - Moves
check_unresolved_exportsfromchecker/mod.rstojavascript.rs - Changes the implementation to traverse program statements directly instead of using unresolved references and node lookup
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/oxc_semantic/src/unresolved_stack.rs | Removes unused root() method |
| crates/oxc_semantic/src/checker/mod.rs | Removes old check_unresolved_exports function and call site, adds new call with program parameter |
| crates/oxc_semantic/src/checker/javascript.rs | Adds new check_unresolved_exports implementation that traverses AST directly |
| crates/oxc_semantic/src/builder.rs | Removes old call to check_unresolved_exports from builder |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #14176 will not alter performanceComparing Summary
Footnotes |
Merge activity
|
…lved_exports` (#14176) part of #13646
ea9dd1e to
3542572
Compare

part of oxc-project/backlog#183