chore(apps/oxlint): tsdown enable arethetypeswrong #14177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables arethetypeswrong (attw) checking in the tsdown configuration for the oxlint app. The change adds type checking capabilities to ensure proper TypeScript type exports.
- Adds @arethetypeswrong/core dependency for type checking validation
- Enables attw checking in tsdown configuration
- Reorganizes oxlint-tsgolint dependency order in package.json
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Adds @arethetypeswrong/core dependency and reorganizes existing dependencies |
| apps/oxlint/tsdown.config.ts | Enables attw type checking by setting attw: true |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
09-27-chore_apps_oxlint_tsdown_enable_arethetypeswrong
branch
from
f467041 to
f1047e9
Compare
graphite-app
bot
deleted the
09-27-chore_apps_oxlint_tsdown_enable_arethetypeswrong
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 28, 2025
`oxlint` package export TS types. `defineRule` and `definePlugin` now give you type-safety and intellisense. Writing plugins in TS is only supported on versions of NodeJS which support type-stripping. Have not added a library (e.g. Jiti) to support older NodeJS versions. Probably some of the types are wrong. But I think this is a decent start. "Are the types wrong" (added in #14177) is reporting an error in `index.d.ts`: ```ts import { VisitorObject as Visitor } from "../dist/generated/visit/visitor.js"; // ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` because the file in `dist/generated/visit` is actually called `visitor.d.ts` (`.d.ts`, not `.js`). I'm not sure if that's a mistake in Rolldown's bundling, "Are the types wrong" being too strict, or a genuine problem. But regardless, TS seems to pick up the types from `visitor.d.ts`, so I think we can probably merge this and look into / fix it later.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Sep 28, 2025
`oxlint` package export TS types. `defineRule` and `definePlugin` now give you type-safety and intellisense. Writing plugins in TS is only supported on versions of NodeJS which support type-stripping. Have not added a library (e.g. Jiti) to support older NodeJS versions. Probably some of the types are wrong. But I think this is a decent start. "Are the types wrong" (added in oxc-project#14177) is reporting an error in `index.d.ts`: ```ts import { VisitorObject as Visitor } from "../dist/generated/visit/visitor.js"; // ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` because the file in `dist/generated/visit` is actually called `visitor.d.ts` (`.d.ts`, not `.js`). I'm not sure if that's a mistake in Rolldown's bundling, "Are the types wrong" being too strict, or a genuine problem. But regardless, TS seems to pick up the types from `visitor.d.ts`, so I think we can probably merge this and look into / fix it later.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Sep 28, 2025
`oxlint` package export TS types. `defineRule` and `definePlugin` now give you type-safety and intellisense. Writing plugins in TS is only supported on versions of NodeJS which support type-stripping. Have not added a library (e.g. Jiti) to support older NodeJS versions. Probably some of the types are wrong. But I think this is a decent start. "Are the types wrong" (added in oxc-project#14177) is reporting an error in `index.d.ts`: ```ts import { VisitorObject as Visitor } from "../dist/generated/visit/visitor.js"; // ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` because the file in `dist/generated/visit` is actually called `visitor.d.ts` (`.d.ts`, not `.js`). I'm not sure if that's a mistake in Rolldown's bundling, "Are the types wrong" being too strict, or a genuine problem. But regardless, TS seems to pick up the types from `visitor.d.ts`, so I think we can probably merge this and look into / fix it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.