-
-
Notifications
You must be signed in to change notification settings - Fork 721
refactor(napi/parser): minify syntax in raw transfer deserializers #14308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(napi/parser): minify syntax in raw transfer deserializers #14308
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #14308 will not alter performanceComparing Summary
Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the raw transfer deserializers by adding minification functionality to remove dead code, preparing for future support of range and parent features. The minification preserves readability while cleaning up the generated code.
Key changes:
- Added minification step to raw transfer deserializer code generation
- Implemented custom minifier function that optimizes code while maintaining readability
- Updated dependencies to use published crate versions instead of workspace versions
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tasks/ast_tools/src/generators/raw_transfer.rs | Added minify function and integrated it into the code generation pipeline |
| tasks/ast_tools/Cargo.toml | Added external dependencies for minification functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@Boshen I've asked for your review as the changes to |
22ea1c9 to
68a4d51
Compare
ab736cf to
8dea470
Compare
8dea470 to
066f4a5
Compare
|
Everything seems to build OK, and tests pass, so I'm going to assume it's working fine, and merge. |
Merge activity
|
…14308) Pure refactor. Minify syntax of raw transfer deserializers. Purpose is not to compress the size of the files per se, but to remove dead code. This is first step towards adding support for `range` and `parent` to raw transfer. `tasks/ast_tools` gains dependencies on `oxc_minify` etc. These have to be dependencies on copies of the published crates from crates.io, NOT local copies (not `workspace = true`). This is because if changes are made to the AST, the local versions of many crates may not compile until after the codegen has run to update code to account for those changes - catch 22. Depending on published versions of the crates avoids this circularity.
066f4a5 to
a98757a
Compare

Pure refactor. Minify syntax of raw transfer deserializers. Purpose is not to compress the size of the files per se, but to remove dead code.
This is first step towards adding support for
rangeandparentto raw transfer.tasks/ast_toolsgains dependencies onoxc_minifyetc. These have to be dependencies on copies of the published crates from crates.io, NOT local copies (notworkspace = true).This is because if changes are made to the AST, the local versions of many crates may not compile until after the codegen has run to update code to account for those changes - catch 22. Depending on published versions of the crates avoids this circularity.