Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 3, 2025

Small fix to JSDoc comments for raw transfer deserialization.

options must be an object at this point because raw transfer code can only be entered if options contains experimentalRawTransfer: true.

Copy link
Member Author

overlookmotel commented Oct 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review October 3, 2025 14:52
@overlookmotel overlookmotel self-assigned this Oct 3, 2025
@overlookmotel overlookmotel changed the base branch from 10-03-refactor_napi_parser_simplify_raw_transfer_deserializer_codegen to graphite-base/14318 October 4, 2025 12:36
@overlookmotel overlookmotel force-pushed the 10-03-fix_napi_parser_fix_jsdoc_comments branch from 6af5548 to 85948c9 Compare October 4, 2025 12:38
@overlookmotel overlookmotel changed the base branch from graphite-base/14318 to 10-03-refactor_napi_parser_simplify_raw_transfer_deserializer_codegen October 4, 2025 12:38
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@overlookmotel overlookmotel force-pushed the 10-03-fix_napi_parser_fix_jsdoc_comments branch from 85948c9 to ef685c8 Compare October 4, 2025 15:42
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
Small fix to JSDoc comments for raw transfer deserialization.

`options` must be an object at this point because raw transfer code can only be entered if `options` contains `experimentalRawTransfer: true`.
@graphite-app graphite-app bot force-pushed the 10-03-refactor_napi_parser_simplify_raw_transfer_deserializer_codegen branch from 7bbe4a5 to 073167a Compare October 4, 2025 15:47
@graphite-app graphite-app bot force-pushed the 10-03-fix_napi_parser_fix_jsdoc_comments branch from ef685c8 to c65e782 Compare October 4, 2025 15:48
Base automatically changed from 10-03-refactor_napi_parser_simplify_raw_transfer_deserializer_codegen to main October 4, 2025 15:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@graphite-app graphite-app bot merged commit c65e782 into main Oct 4, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 10-03-fix_napi_parser_fix_jsdoc_comments branch October 4, 2025 15:53
@Boshen Boshen mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants