Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 14, 2025

Using a match means we only need to call one function instead of two. Also enables the linter codegen to analyze this rule.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 14, 2025
Copy link
Member Author

camchenry commented Oct 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry force-pushed the 10-13-refactor_linter_improve_support_for_const_using_declarations branch from 0f9d2ce to 4b42d75 Compare October 14, 2025 03:21
@camchenry camchenry force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch from 041b2be to 47481cf Compare October 14, 2025 03:21
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #14581 will not alter performance

Comparing 10-13-perf_linter_use_top-level_match_for_const-comparisons_ (8df1e24) with main (cf9f56c)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (8df1e24) during the generation of this report, so cf9f56c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camchenry camchenry force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch from 47481cf to e1c5fe2 Compare October 14, 2025 03:23
@camchenry camchenry force-pushed the 10-13-refactor_linter_improve_support_for_const_using_declarations branch from 4b42d75 to 9bda6c2 Compare October 14, 2025 03:23
@camchenry camchenry changed the base branch from 10-13-refactor_linter_improve_support_for_const_using_declarations to graphite-base/14581 October 14, 2025 03:25
@camchenry camchenry force-pushed the graphite-base/14581 branch from 4b42d75 to f29ac19 Compare October 14, 2025 03:25
@camchenry camchenry force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch from e1c5fe2 to ec8228f Compare October 14, 2025 03:25
@camchenry camchenry changed the base branch from graphite-base/14581 to 10-13-perf_linter_run_no-const-assign_on_ast_node_instead_of_symbols October 14, 2025 03:25
@camchenry camchenry force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch from ec8228f to 89cb41e Compare October 14, 2025 03:29
@camchenry camchenry changed the base branch from 10-13-perf_linter_run_no-const-assign_on_ast_node_instead_of_symbols to 10-13-perf_linter_run_no-class-assign_on_class_nodes_instead_of_symbols October 14, 2025 03:29
@camchenry camchenry marked this pull request as ready for review October 14, 2025 03:39
@camchenry camchenry requested a review from camc314 as a code owner October 14, 2025 03:39
@camc314 camc314 changed the base branch from 10-13-perf_linter_run_no-class-assign_on_class_nodes_instead_of_symbols to graphite-base/14581 October 14, 2025 08:13
@camc314 camc314 force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch from 89cb41e to 3e0b697 Compare October 14, 2025 08:13
@camc314 camc314 force-pushed the graphite-base/14581 branch from a5e3c7f to c4e12df Compare October 14, 2025 08:13
@camc314 camc314 changed the base branch from graphite-base/14581 to main October 14, 2025 08:13
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 14, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Oct 14, 2025
Using a match means we only need to call one function instead of two. Also enables the linter codegen to analyze this rule.
Copilot AI review requested due to automatic review settings October 14, 2025 08:18
@graphite-app graphite-app bot force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch from 3e0b697 to 9e3c128 Compare October 14, 2025 08:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Using a match means we only need to call one function instead of two. Also enables the linter codegen to analyze this rule.
@graphite-app graphite-app bot force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch from 9e3c128 to 8df1e24 Compare October 14, 2025 08:21
@graphite-app graphite-app bot merged commit 8df1e24 into main Oct 14, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch October 14, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants