Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 15, 2025

Previous PRs removed most usage of this run function, and this migrates the rest to use run_once. The motivation for this is not performance (this is likely a slight regression, actually), but should be a slight benefit to binary size and general maintenance. We now only have 3 ways of running lint rules, which makes the linter runtime code simpler.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #14610 will not alter performance

Comparing 10-14-refactor_linter_remove_run_on_symbol_ (90f5f89) with main (676ee99)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (0485859) during the generation of this report, so 676ee99 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member Author

camchenry commented Oct 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2025

Merge activity

- closes https://github.com/oxc-project/backlog/issues/191

Previous PRs removed most usage of this run function, and this migrates the rest to use `run_once`. The motivation for this is not performance (this is likely a slight regression, actually), but should be a slight benefit to binary size and general maintenance. We now only have 3 ways of running lint rules, which makes the linter runtime code simpler.
@graphite-app graphite-app bot force-pushed the 10-14-perf_linter_update_no-const-assign_to_run_on_nodes_instead_of_symbols branch from a56cb68 to 0485859 Compare October 15, 2025 09:17
@graphite-app graphite-app bot force-pushed the 10-14-refactor_linter_remove_run_on_symbol_ branch from 41974d1 to 90f5f89 Compare October 15, 2025 09:18
Base automatically changed from 10-14-perf_linter_update_no-const-assign_to_run_on_nodes_instead_of_symbols to main October 15, 2025 09:21
@graphite-app graphite-app bot merged commit 90f5f89 into main Oct 15, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-14-refactor_linter_remove_run_on_symbol_ branch October 15, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linter: remove run_on_symbol?

3 participants