-
-
Notifications
You must be signed in to change notification settings - Fork 708
refactor(linter): remove run_on_symbol
#14610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(linter): remove run_on_symbol
#14610
Conversation
CodSpeed Performance ReportMerging #14610 will not alter performanceComparing Summary
Footnotes
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
- closes https://github.com/oxc-project/backlog/issues/191 Previous PRs removed most usage of this run function, and this migrates the rest to use `run_once`. The motivation for this is not performance (this is likely a slight regression, actually), but should be a slight benefit to binary size and general maintenance. We now only have 3 ways of running lint rules, which makes the linter runtime code simpler.
a56cb68 to
0485859
Compare
41974d1 to
90f5f89
Compare

run_on_symbol? #14644Previous PRs removed most usage of this run function, and this migrates the rest to use
run_once. The motivation for this is not performance (this is likely a slight regression, actually), but should be a slight benefit to binary size and general maintenance. We now only have 3 ways of running lint rules, which makes the linter runtime code simpler.