Skip to content

refactor(linter/no-process-env): restructure match to improve generated node types #14643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

refactor(linter/no-process-env): restructure match to improve generated node types #14643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1820,7 +1820,10 @@ impl RuleRunner for crate::rules::node::no_new_require::NoNewRequire {
}

impl RuleRunner for crate::rules::node::no_process_env::NoProcessEnv {
const NODE_TYPES: Option<&AstTypesBitset> = None;
const NODE_TYPES: Option<&AstTypesBitset> = Some(&AstTypesBitset::from_types(&[
AstType::ComputedMemberExpression,
AstType::StaticMemberExpression,
]));
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

Expand Down
40 changes: 15 additions & 25 deletions crates/oxc_linter/src/rules/node/no_process_env.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,31 +84,21 @@ impl Rule for NoProcessEnv {

fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
// Match `process.env` as either static `process.env` or computed `process["env"]`
let mut is_process_env_member = false;
let mut current_span = Span::default();

match node.kind() {
AstKind::StaticMemberExpression(mem) => {
if mem.property.name.as_str() == "env" && is_process_global_object(&mem.object, ctx)
{
is_process_env_member = true;
current_span = mem.span;
}
let span = match node.kind() {
AstKind::StaticMemberExpression(mem)
if mem.property.name.as_str() == "env"
&& is_process_global_object(&mem.object, ctx) =>
{
mem.span
}
AstKind::ComputedMemberExpression(mem) => {
AstKind::ComputedMemberExpression(mem)
if mem.static_property_name().is_some_and(|name| name.as_str() == "env")
&& is_process_global_object(&mem.object, ctx)
{
is_process_env_member = true;
current_span = mem.span;
}
&& is_process_global_object(&mem.object, ctx) =>
{
mem.span
}
_ => {}
}

if !is_process_env_member {
return;
}
_ => return,
};

// Default: report any `process.env` usage
let mut should_report = true;
Expand All @@ -117,7 +107,7 @@ impl Rule for NoProcessEnv {
match ctx.nodes().parent_kind(node.id()) {
AstKind::StaticMemberExpression(parent_mem) => {
if let Some(obj_mem) = parent_mem.object.as_member_expression()
&& obj_mem.span() == current_span
&& obj_mem.span() == span
{
let (.., prop_name) = parent_mem.static_property_info();
if self.0.allowed_variables.contains(prop_name) {
Expand All @@ -127,7 +117,7 @@ impl Rule for NoProcessEnv {
}
AstKind::ComputedMemberExpression(parent_mem) => {
if let Some(obj_mem) = parent_mem.object.as_member_expression()
&& obj_mem.span() == current_span
&& obj_mem.span() == span
&& let Some((_, name)) = parent_mem.static_property_info()
&& self.0.allowed_variables.contains(name)
{
Expand All @@ -138,7 +128,7 @@ impl Rule for NoProcessEnv {
}

if should_report {
ctx.diagnostic(no_process_env_diagnostic(current_span));
ctx.diagnostic(no_process_env_diagnostic(span));
}
}
}
Expand Down
Loading