From 1217411d1314f91da275d4462d161f26707064ce Mon Sep 17 00:00:00 2001
From: camchenry <1514176+camchenry@users.noreply.github.com>
Date: Fri, 17 Oct 2025 10:26:39 +0000
Subject: [PATCH] perf(linter): refactor class-methods-use-this to be analyzed
 (#14687)

Remove `let` statement that blocks simple node type analysis.
---
 .../src/generated/rule_runner_impls.rs        |  6 ++++-
 .../rules/eslint/class_methods_use_this.rs    | 25 ++++++++++++-------
 2 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/crates/oxc_linter/src/generated/rule_runner_impls.rs b/crates/oxc_linter/src/generated/rule_runner_impls.rs
index 01ad8309edf69..567b5d2924df4 100644
--- a/crates/oxc_linter/src/generated/rule_runner_impls.rs
+++ b/crates/oxc_linter/src/generated/rule_runner_impls.rs
@@ -27,7 +27,11 @@ impl RuleRunner for crate::rules::eslint::block_scoped_var::BlockScopedVar {
 }
 
 impl RuleRunner for crate::rules::eslint::class_methods_use_this::ClassMethodsUseThis {
-    const NODE_TYPES: Option<&AstTypesBitset> = None;
+    const NODE_TYPES: Option<&AstTypesBitset> = Some(&AstTypesBitset::from_types(&[
+        AstType::AccessorProperty,
+        AstType::MethodDefinition,
+        AstType::PropertyDefinition,
+    ]));
     const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
 }
 
diff --git a/crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs b/crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs
index e9595ca37a1d1..035883c66f969 100644
--- a/crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs
+++ b/crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs
@@ -1,4 +1,4 @@
-use std::borrow::Cow;
+use std::{borrow::Cow, ops::Deref};
 
 use itertools::Itertools;
 use oxc_ast::{
@@ -42,6 +42,14 @@ impl Default for ClassMethodsUseThisConfig {
 #[derive(Debug, Clone, Default)]
 pub struct ClassMethodsUseThis(Box<ClassMethodsUseThisConfig>);
 
+impl Deref for ClassMethodsUseThis {
+    type Target = ClassMethodsUseThisConfig;
+
+    fn deref(&self) -> &Self::Target {
+        &self.0
+    }
+}
+
 #[derive(Debug, Clone)]
 struct MethodException {
     name: CompactStr,
@@ -136,12 +144,11 @@ impl Rule for ClassMethodsUseThis {
     }
 
     fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
-        let config = &self.0;
         let function_pair = match node.kind() {
             AstKind::AccessorProperty(accessor) => {
                 if accessor.r#static
-                    || !config.enforce_for_class_fields
-                    || (config.ignore_override_methods && accessor.r#override)
+                    || !self.enforce_for_class_fields
+                    || (self.ignore_override_methods && accessor.r#override)
                     || self.check_ignore_classes_with_implements(
                         node,
                         ctx,
@@ -164,7 +171,7 @@ impl Rule for ClassMethodsUseThis {
             AstKind::MethodDefinition(method_definition) => {
                 if method_definition.r#static
                     || method_definition.kind.is_constructor()
-                    || (config.ignore_override_methods && method_definition.r#override)
+                    || (self.ignore_override_methods && method_definition.r#override)
                     || self.check_ignore_classes_with_implements(
                         node,
                         ctx,
@@ -179,8 +186,8 @@ impl Rule for ClassMethodsUseThis {
             }
             AstKind::PropertyDefinition(property_definition) => {
                 if property_definition.r#static
-                    || !config.enforce_for_class_fields
-                    || (config.ignore_override_methods && property_definition.r#override)
+                    || !self.enforce_for_class_fields
+                    || (self.ignore_override_methods && property_definition.r#override)
                     || self.check_ignore_classes_with_implements(
                         node,
                         ctx,
@@ -200,11 +207,11 @@ impl Rule for ClassMethodsUseThis {
                     _ => None,
                 })
             }
-            _ => None,
+            _ => return,
         };
         let Some((function_body, name)) = function_pair else { return };
         if let Some(name_str) = name.name()
-            && config.except_methods.iter().any(|method| {
+            && self.except_methods.iter().any(|method| {
                 method.name == name_str && method.private == name.is_private_identifier()
             })
         {