Skip to content

perf(linter): move root scope check into match arms in import/no-webpack-loader-syntax #14691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

perf(linter): move root scope check into match arms in import/no-webpack-loader-syntax #14691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1175,7 +1175,8 @@ impl RuleRunner for crate::rules::import::no_unassigned_import::NoUnassignedImpo
}

impl RuleRunner for crate::rules::import::no_webpack_loader_syntax::NoWebpackLoaderSyntax {
const NODE_TYPES: Option<&AstTypesBitset> = None;
const NODE_TYPES: Option<&AstTypesBitset> =
Some(&AstTypesBitset::from_types(&[AstType::CallExpression, AstType::ImportDeclaration]));
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

Expand Down
15 changes: 10 additions & 5 deletions crates/oxc_linter/src/rules/import/no_webpack_loader_syntax.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,6 @@ declare_oxc_lint!(

impl Rule for NoWebpackLoaderSyntax {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
// not in top level
if node.scope_id() != ctx.scoping().root_scope_id() {
return;
}

match node.kind() {
AstKind::CallExpression(call_expr) => {
if let Expression::Identifier(identifier) = &call_expr.callee {
Expand All @@ -74,6 +69,11 @@ impl Rule for NoWebpackLoaderSyntax {
return;
};

// not in top level
if node.scope_id() != ctx.scoping().root_scope_id() {
return;
}

if ident.value.contains('!') {
ctx.diagnostic(no_named_as_default_diagnostic(
ident.value.as_str(),
Expand All @@ -83,6 +83,11 @@ impl Rule for NoWebpackLoaderSyntax {
}
}
AstKind::ImportDeclaration(import_decl) => {
// not in top level
if node.scope_id() != ctx.scoping().root_scope_id() {
return;
}

if import_decl.source.value.contains('!') {
ctx.diagnostic(no_named_as_default_diagnostic(
&import_decl.source.value,
Expand Down
Loading