Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 17, 2025

Use diverging match node.kind() instead of if !matches!(node.kind(), ...)

Copy link
Member Author

camchenry commented Oct 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 17, 2025

CodSpeed Performance Report

Merging #14692 will not alter performance

Comparing 10-16-perf_linter_refactor_jest_no-conditional-in-test_to_use_diverging_match (c8d775c) with 10-16-perf_linter_move_root_scope_check_into_match_arms_in_import_no-webpack-loader-syntax_ (b666c26)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 17, 2025

Merge activity

@camc314 camc314 self-assigned this Oct 17, 2025
… match (#14692)

Use diverging `match node.kind()` instead of `if !matches!(node.kind(), ...)`
@graphite-app graphite-app bot force-pushed the 10-16-perf_linter_move_root_scope_check_into_match_arms_in_import_no-webpack-loader-syntax_ branch from 612e8fd to b666c26 Compare October 17, 2025 10:29
@graphite-app graphite-app bot force-pushed the 10-16-perf_linter_refactor_jest_no-conditional-in-test_to_use_diverging_match branch from 9e7eb85 to c8d775c Compare October 17, 2025 10:29
Base automatically changed from 10-16-perf_linter_move_root_scope_check_into_match_arms_in_import_no-webpack-loader-syntax_ to main October 17, 2025 10:38
@graphite-app graphite-app bot merged commit c8d775c into main Oct 17, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 10-16-perf_linter_refactor_jest_no-conditional-in-test_to_use_diverging_match branch October 17, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants