Skip to content

refactor(linter/plugins): rename function #14726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

refactor(linter/plugins): rename function #14726

merged 1 commit into from
Oct 17, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 17, 2025 •
edited
Loading

Trivial change. Rename this function to better describe what it does.

@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Oct 17, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Oct 17, 2025
@overlookmotel overlookmotel mentioned this pull request Oct 17, 2025
Merged
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 17, 2025
@overlookmotel overlookmotel marked this pull request as ready for review October 17, 2025 13:08
Copilot AI review requested due to automatic review settings October 17, 2025 13:08
Copilot AI reviewed Oct 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames a function from resetSource to resetSourceAndAst to better reflect its actual functionality of resetting both source code and AST data structures.

  • Renamed function from resetSource to resetSourceAndAst
  • Updated function documentation and usage comments to reflect the broader scope
  • Updated import statement to use the new function name

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/oxlint/src-js/plugins/source_code.ts Renamed function and updated its documentation to clarify it resets both source and AST
apps/oxlint/src-js/plugins/lint.ts Updated import and function call to use the new name, with corresponding comment update

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel self-assigned this Oct 17, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 17, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Oct 17, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
refactor(linter/plugins): rename function (#14726)
b402024 
Trivial change. Rename this function to better describe what it does.
@graphite-app graphite-app bot force-pushed the 10-17-refactor_linter_plugins_rename_function branch from 4568276 to b402024 Compare October 17, 2025 13:18
@graphite-app graphite-app bot merged commit b402024 into main Oct 17, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 10-17-refactor_linter_plugins_rename_function branch October 17, 2025 13:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 17, 2025
@Boshen Boshen mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel