Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Oct 18, 2025

No description provided.

Copy link
Member Author

Sysix commented Oct 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot changed the base branch from 10-15-refactor_language_server_improve_file_watching_for_different_tools to graphite-base/14746 October 18, 2025 10:50
@graphite-app graphite-app bot force-pushed the 10-18-feat_language_server_able_to_set_off_for_run_configuration branch from f9ab58b to f8258b1 Compare October 18, 2025 10:56
@graphite-app graphite-app bot force-pushed the graphite-base/14746 branch from 74ad10b to 699c91c Compare October 18, 2025 10:56
@graphite-app graphite-app bot changed the base branch from graphite-base/14746 to main October 18, 2025 10:56
@graphite-app graphite-app bot force-pushed the 10-18-feat_language_server_able_to_set_off_for_run_configuration branch from f8258b1 to 9d81083 Compare October 18, 2025 10:56
@Sysix Sysix force-pushed the 10-18-feat_language_server_able_to_set_off_for_run_configuration branch 3 times, most recently from 0db9067 to ec7bcd3 Compare October 18, 2025 14:00
@nrayburn-tech
Copy link
Collaborator

Probably not something you have to fix now, but the properties should probably be reviewed and renamed to better match how they are used. Meaning if it's a property only for the linter, then something like oxc.linter.run. Something only for the formatter, oxc.formatter.run. Something for both, oxc.run. Just a suggestion for the future.

@Sysix Sysix force-pushed the 10-18-feat_language_server_able_to_set_off_for_run_configuration branch from ec7bcd3 to 1c363a6 Compare October 20, 2025 18:43
@Sysix
Copy link
Member Author

Sysix commented Oct 20, 2025

@nrayburn-tech agree, Goal is to rename all options to have a lint. or fmt. prefix.
Of course, if we still use one language server for both tools :)

@Sysix Sysix requested a review from Copilot October 20, 2025 20:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for disabling the linter via a new Run::Off configuration option, allowing users to completely turn off linting in the language server.

Key changes:

  • Introduced Run::Off as a new variant in the linter configuration enum
  • Modified worker logic to conditionally initialize and refresh the linter based on the Run::Off setting
  • Added handling for dynamic enabling/disabling of the linter through configuration changes

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/oxc_language_server/src/linter/options.rs Added Run::Off enum variant to support disabling the linter
crates/oxc_language_server/src/worker.rs Implemented conditional linter initialization, refresh logic, and watcher registration/unregistration based on Run::Off state
crates/oxc_language_server/src/linter/server_linter.rs Updated linter run logic to handle Run::Off state and watch pattern registration when transitioning from off to on
crates/oxc_language_server/src/tester.rs Added panic guard for disabled linter state in test helper
crates/oxc_language_server/README.md Updated documentation to include "off" as a valid value for the run configuration option

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Sysix Sysix force-pushed the 10-18-feat_language_server_able_to_set_off_for_run_configuration branch from 1c363a6 to 181d253 Compare October 20, 2025 20:21
@camc314 camc314 self-assigned this Oct 23, 2025
@Sysix
Copy link
Member Author

Sysix commented Oct 31, 2025

Because there will be oxlint --lsp and oxfmt --lsp integration, I do not think an "off" for oxlint --lsp makes sense.
-> Closing

@Sysix Sysix closed this Oct 31, 2025
@Sysix Sysix deleted the 10-18-feat_language_server_able_to_set_off_for_run_configuration branch November 10, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants