Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 18, 2025

Follow-on after #14715. Pure refactor. Move code for SourceCode's comment-related methods into a separate file. Code is completely unchanged - it's just moved.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Oct 18, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 18, 2025
@overlookmotel overlookmotel marked this pull request as ready for review October 18, 2025 13:33
@overlookmotel overlookmotel requested review from Copilot and removed request for camc314 October 18, 2025 13:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the SourceCode implementation by extracting comment-related methods into a separate comments.ts file. The functionality remains unchanged - this is purely a code organization improvement.

Key changes:

  • Created new comments.ts file to house all comment-related functions
  • Converted SourceCode methods to standalone exported functions
  • Updated source_code.ts to import and re-export these functions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/oxlint/src-js/plugins/source_code.ts Removed comment-related method implementations and replaced with imports/re-exports from new comments module
apps/oxlint/src-js/plugins/comments.ts New file containing all comment-related functions extracted from SourceCode, including getAllComments, getCommentsBefore, getCommentsAfter, getCommentsInside, and commentsExistBetween

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel self-assigned this Oct 18, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 18, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 18, 2025

Merge activity

…le (#14753)

Follow-on after #14715. Pure refactor. Move code for `SourceCode`'s comment-related methods into a separate file. Code is completely unchanged - it's just moved.
@graphite-app graphite-app bot force-pushed the 10-18-refactor_linter_plugins_move_comments-related_code_into_separate_file branch from 8fdd1af to ec816ba Compare October 18, 2025 13:36
@graphite-app graphite-app bot merged commit ec816ba into main Oct 18, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 10-18-refactor_linter_plugins_move_comments-related_code_into_separate_file branch October 18, 2025 13:41
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants