Skip to content

Conversation

@connorshea
Copy link
Contributor

@connorshea connorshea commented Oct 19, 2025

Closing code blocks were missing in the examples sections of both these rules.

As you can see on the website pages here:

A closing code block was missing in the examples section.
@connorshea connorshea requested a review from camc314 as a code owner October 19, 2025 22:41
Copilot AI review requested due to automatic review settings October 19, 2025 22:41
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 19, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a documentation formatting issue in the no_plusplus linting rule by adding a missing closing code block marker.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation labels Oct 19, 2025
@connorshea connorshea changed the title docs(linter): Fix the no_plusplus rule documentation. docs(linter): Fix the no-plusplus and no-irregular-whitespace rule documentation. Oct 19, 2025
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yoU!

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #14790 will not alter performance

Comparing connorshea:cshea/fix-noplusplus (f94a3c9) with main (d39bed0)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 changed the title docs(linter): Fix the no-plusplus and no-irregular-whitespace rule documentation. docs(linter): improve no-plusplus and no-irregular-whitespace rule docs Oct 20, 2025
@camc314 camc314 merged commit 7b64f27 into oxc-project:main Oct 20, 2025
24 checks passed
@camc314 camc314 self-assigned this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants