feat(linter): add plugin for angular and implement rule prefer standalone #14959

pchorus · 2025-10-26T20:31:37Z

This PR adds support for Angular ESLint rules according to angular-eslint/angular-eslint.

It also implements first recommended rule prefer-standalone.

graphite-app · 2025-10-26T20:31:44Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

camc314 · 2025-10-26T20:33:01Z

I think this would be better as an external plugin? Does the angular eslint plugin not work with oxlint?

graphite-app · 2025-10-26T20:34:54Z

crates/oxc_linter/src/rules/angular/prefer_standalone.rs

+                if !bool_value.value {
+                    ctx.diagnostic_with_suggestion(
+                        prefer_standalone_diagnostic(prop.span()),
+                        |fixer| fixer.replace(prop.span(), ""),


The auto-fix produces invalid JavaScript syntax. When removing standalone: false, from the middle of an object, it leaves a leading comma on the next property. The test expectations show this bug:

@Component({ , // <- Invalid syntax! template: '<div></div>' })

Fix: The fixer needs to handle comma removal properly. Replace with logic that removes the property along with its trailing comma, or if it's the last property, remove it along with the preceding comma.

Suggested change

|fixer| fixer.replace(prop.span(), ""),

|fixer| {

// Get the text of the entire file

let source = fixer.source_text();

let span = prop.span();

// Find the next non-whitespace character after the property

let mut end = span.end;

while end < source.len() && (source.as_bytes()[end] as char).is_whitespace() {

end += 1;

}

// If the next character is a comma, include it in the removal

if end < source.len() && source.as_bytes()[end] as char == ',' {

end += 1;

fixer.replace(oxc_span::Span::new(span.start, end), "")

} else {

// Otherwise, look for a preceding comma

let mut start = span.start;

while start > 0 && (source.as_bytes()[start - 1] as char).is_whitespace() {

start -= 1;

}

// If there's a comma before the property, remove it too

if start > 0 && source.as_bytes()[start - 1] as char == ',' {

start -= 1;

fixer.replace(oxc_span::Span::new(start, span.end), "")

} else {

fixer.replace(span, "")

}

}

},

Spotted by Graphite Agent

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-10-26T20:34:56Z

tasks/rulegen/src/main.rs

+const ANGULAR_TEST_PATH: &str =
+    "https://raw.githubusercontent.com/angular-eslint/angular-eslint/tree/main/packages/eslint-plugin/tests/rules";
+const ANGULAR_RULES_PATH: &str =
+    "https://raw.githubusercontent.com/angular-eslint/angular-eslint/tree/main/packages/eslint-plugin/src/rules";


The URLs contain /tree/main/ which is incorrect for raw.githubusercontent.com. This path segment is only used in the GitHub web interface, not for raw content access. These URLs will return 404 errors when the rule generator tries to fetch documentation.

Fix: Remove /tree from the URLs:

const ANGULAR_TEST_PATH: &str = "https://raw.githubusercontent.com/angular-eslint/angular-eslint/main/packages/eslint-plugin/tests/rules"; const ANGULAR_RULES_PATH: &str = "https://raw.githubusercontent.com/angular-eslint/angular-eslint/main/packages/eslint-plugin/src/rules";

Suggested change

const ANGULAR_TEST_PATH: &str =

"https://raw.githubusercontent.com/angular-eslint/angular-eslint/tree/main/packages/eslint-plugin/tests/rules";

const ANGULAR_RULES_PATH: &str =

"https://raw.githubusercontent.com/angular-eslint/angular-eslint/tree/main/packages/eslint-plugin/src/rules";

const ANGULAR_TEST_PATH: &str =

"https://raw.githubusercontent.com/angular-eslint/angular-eslint/main/packages/eslint-plugin/tests/rules";

const ANGULAR_RULES_PATH: &str =

"https://raw.githubusercontent.com/angular-eslint/angular-eslint/main/packages/eslint-plugin/src/rules";

Spotted by Graphite Agent

Is this helpful? React 👍 or 👎 to let us know.

crates/oxc_linter/src/rules/angular/prefer_standalone.rs

pchorus · 2025-10-26T20:37:27Z

@TheAlexLichter Here is the PR as discussed.

pchorus · 2025-10-27T20:35:15Z

I think this would be better as an external plugin? Does the angular eslint plugin not work with oxlint?

I will check.

pchorus · 2025-10-27T21:08:22Z

I think this would be better as an external plugin? Does the angular eslint plugin not work with oxlint?

I tried to use oxlint with the angular-eslint package containing the eslint plugin in some of my Angular projects.
I created the .oxlintrc.json containing

{
  "$schema": "./node_modules/oxlint/configuration_schema.json",
  "plugins": [],
  "jsPlugins": ["angular-eslint"],
...
}

When running oxlint I get the following error:

WARNING: JS plugins are experimental and not subject to semver.
Breaking changes are possible while JS plugins support is under development.
Failed to parse configuration file.

  × Failed to load JS plugin: angular-eslint
  │   TypeError: Cannot read properties of undefined (reading 'name')
  │     at loadPluginImpl (file:///xxxxxx/xxxxxx/development/and-action/node_modules/oxlint/dist/plugins.js:820:31)
  │     at async loadPlugin (file:///xxxxxx/xxxxxx/development/and-action/node_modules/oxlint/dist/plugins.js:810:13)

@camc314 What do you mean by "external plugin"? Do you refer to the current ESLint plugin?

Sysix · 2025-10-28T20:54:47Z

@pchorus it should be @angular/eslint-plugin, but we there are some resolving name problems, which will be fixed with: #15010

camc314 · 2025-10-29T12:26:30Z

yeah, by external, i mean not built into oxlint e.g. JS plugin

Let see in the next release (later today) if it's working as expected, and go from there

pchorus · 2025-10-29T21:22:11Z

@camc314 Sounds good. As soon as the new version is released I will give it a try.

Anyways, that means that rules for Angular are still written in JS. So my understanding is that migrating them to Rust would make all of them faster as well.

Are there any plans to include more JS-based rules into Rust?
Do you plan to allow external plugins written in Rust?

I would try to help with some stuff since most projects I work on are Angular projects and I would be happy to use Oxlint instead of ESLint.

pchorus · 2025-10-30T11:34:35Z

yeah, by external, i mean not built into oxlint e.g. JS plugin

Let see in the next release (later today) if it's working as expected, and go from there

@camc314 Now it seems to work as expected with @angular-eslint/eslint-plugin. 👍🏻
I still have the question from my comment above on what do you think about migrating Angular rules to Rust somehow.

camc314 · 2025-10-30T12:40:32Z

@camc314 Now it seems to work as expected with @angular-eslint/eslint-plugin. 👍🏻

awesome, i'm glad it's working

Anyways, that means that rules for Angular are still written in JS. So my understanding is that migrating them to Rust would make all of them faster as well.

Yes, migrating the angular rules to rust would likley improve performance.

Are there any plans to include more JS-based rules into Rust?

Not at this time, once custom JS plugins and type aware linting is more stable, we may re-evaluate. The main reasoning for this is just the high maintence burden of supporting more plugins when the JS version is probably fast enough for most people's use cases. That said, if demand for a particular plugin is incredibly high, we may re-evaluate that decision.

Do you plan to allow external plugins written in Rust?

This is a more complex topic, we're hoping that custom JS plugins with raw transfer will be fast enough such that we don't need to build out a rust based plugin system.

camc314 · 2025-10-30T12:41:00Z

Thanks for working on this, and for using oxlint, but i'm going to close this for now.

pchorus · 2025-10-30T19:22:56Z

@camc314 Thank you for sharing some insights about your plans and your point of view.
That sounds absolutely reasonable to me.

Thanks for working on this, and for using oxlint, but i'm going to close this for now.

Sure, thanks for your support.
I will check if I can possibly contribute to other oxlint regarding topics that actually help pushing it forward.

refactor(linter): prepare code for Angular rules

669738d

pchorus requested a review from camc314 as a code owner October 26, 2025 20:31

github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Oct 26, 2025

graphite-app bot reviewed Oct 26, 2025

View reviewed changes

pchorus commented Oct 26, 2025

View reviewed changes

crates/oxc_linter/src/rules/angular/prefer_standalone.rs Outdated Show resolved Hide resolved

pchorus changed the title ~~10 24 feat linter angular prefer standalone~~ feat(linter): add plugin for angular and implement rule prefer standalone Oct 26, 2025

github-actions bot added the C-enhancement Category - New feature or request label Oct 26, 2025

pchorus mentioned this pull request Oct 27, 2025

eslint-plugin-angular #14958

Closed

feat(linter): add angular/prefer-standalone

03d3d4d

pchorus force-pushed the 10-24-feat_linter_angular_prefer_standalone branch from 5e90396 to 03d3d4d Compare October 27, 2025 20:32

camc314 closed this Oct 30, 2025

TheAlexLichter mentioned this pull request Nov 2, 2025

chore(contribution): add info about halt on new rust plugins for oxlint oxc-project/oxc-project.github.io#588

Merged

pchorus deleted the 10-24-feat_linter_angular_prefer_standalone branch November 9, 2025 19:52

-                        |fixer| fixer.replace(prop.span(), ""),
+                        |fixer| {
+                            // Get the text of the entire file
+                            let source = fixer.source_text();
+                            let span = prop.span();
+                            // Find the next non-whitespace character after the property
+                            let mut end = span.end;
+                            while end < source.len() && (source.as_bytes()[end] as char).is_whitespace() {
+                                end += 1;
+                            }
+                            // If the next character is a comma, include it in the removal
+                            if end < source.len() && source.as_bytes()[end] as char == ',' {
+                                end += 1;
+                                fixer.replace(oxc_span::Span::new(span.start, end), "")
+                            } else {
+                                // Otherwise, look for a preceding comma
+                                let mut start = span.start;
+                                while start > 0 && (source.as_bytes()[start - 1] as char).is_whitespace() {
+                                    start -= 1;
+                                }
+                                // If there's a comma before the property, remove it too
+                                if start > 0 && source.as_bytes()[start - 1] as char == ',' {
+                                    start -= 1;
+                                    fixer.replace(oxc_span::Span::new(start, span.end), "")
+                                } else {
+                                    fixer.replace(span, "")
+                                }
+                            }
+                        },

Uh oh!

feat(linter): add plugin for angular and implement rule prefer standalone #14959

feat(linter): add plugin for angular and implement rule prefer standalone #14959

Uh oh!

Conversation

pchorus commented Oct 26, 2025

Uh oh!

graphite-app bot commented Oct 26, 2025

How to use the Graphite Merge Queue

Uh oh!

camc314 commented Oct 26, 2025

Uh oh!

graphite-app bot Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pchorus commented Oct 26, 2025

Uh oh!

pchorus commented Oct 27, 2025

Uh oh!

pchorus commented Oct 27, 2025

Uh oh!

Sysix commented Oct 28, 2025

Uh oh!

camc314 commented Oct 29, 2025

Uh oh!

pchorus commented Oct 29, 2025

Uh oh!

pchorus commented Oct 30, 2025

Uh oh!

camc314 commented Oct 30, 2025

Uh oh!

camc314 commented Oct 30, 2025

Uh oh!

pchorus commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants