Skip to content

Conversation

@TheAlexLichter
Copy link
Member

@TheAlexLichter TheAlexLichter commented Oct 28, 2025

Inspired by #14587, the command flag was missing for them too.

Expected: oxlint --type-aware --deny typescript/await-thenable
Actual: oxlint --deny typescript/await-thenable

image

Copilot AI review requested due to automatic review settings October 28, 2025 23:18
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for displaying the --type-aware flag in CLI usage examples for TypeScript-specific linting rules (tsgolint rules) in the generated documentation.

  • Conditionally includes --type-aware flag in bash examples based on whether a rule is a tsgolint rule
  • Updates both default plugin and non-default plugin CLI example formats

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Alexander Lichter <github@lichter.io>
@camchenry camchenry changed the title docs: show type-aware command if rule is tsgolint-based docs(linter): show type-aware command if rule is tsgolint-based Oct 28, 2025
@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Oct 28, 2025
@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Oct 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 29, 2025

Merge activity

  • Oct 29, 3:19 AM UTC: @TheAlexLichter we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 29, 2025
@camchenry camchenry merged commit 6faa11d into oxc-project:main Oct 29, 2025
19 checks passed
@TheAlexLichter TheAlexLichter deleted the docs-type-aware branch October 29, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants