Skip to content

perf(linter/plugins): faster check for cwd #15301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

perf(linter/plugins): faster check for cwd #15301

merged 1 commit into from
Nov 5, 2025
+4 −3

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 5, 2025 •
edited
Loading

Follow-on after #14814. Small perf optimization. cwd is either null or a string, so use cheaper === null check instead of ?? (which is equivalent to cwd === null || cwd === undefined).

Also rename the var, just for brevity.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-performance Category - Solution not expected to change functional behavior, only performance labels Nov 5, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review November 5, 2025 10:32
Copilot AI review requested due to automatic review settings November 5, 2025 10:32
@overlookmotel overlookmotel self-assigned this Nov 5, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 5, 2025 •
edited by graphite-app bot
Loading

Merge activity

Copilot AI reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the current working directory caching mechanism in the Context class. The change removes the getInternal validation check when accessing context.cwd since the current working directory is a global property that can be safely accessed even within createOnce.

  • Renamed cachedCwd to cwd for clarity
  • Removed the getInternal() guard from the cwd getter to allow access in createOnce
  • Replaced nullish coalescing with an explicit null check

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel
perf(linter/plugins): faster check for cwd (#15301)
ee9f2f4 
Follow-on after #14814. Small perf optimization. `cwd` is either `null` or a string, so use cheaper `=== null` check instead of `??` (which is equivalent to `cwd === null || cwd === undefined`).

Also rename the var, just for brevity.
@graphite-app graphite-app bot force-pushed the 11-04-perf_linter_plugins_faster_check_for_cwd_ branch from 074d0f0 to ee9f2f4 Compare November 5, 2025 10:38
@graphite-app graphite-app bot merged commit ee9f2f4 into main Nov 5, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-04-perf_linter_plugins_faster_check_for_cwd_ branch November 5, 2025 10:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
@Boshen Boshen mentioned this pull request Nov 5, 2025
Merged
@overlookmotel overlookmotel mentioned this pull request Nov 8, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Nov 8, 2025
@overlookmotel
fix(linter/plugins): allow access to cwd in createOnce in ESLint …
7409630 
…interop mode (#15488)

#15301 made `Context#cwd` available in `createOnce`. Make it available in ESLint compat mode too. Ditto the `extend` method added in #15477.

Define all other `Context` methods/getters on prototype of `Context` in ESLint compat mode, for completeness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel