fix(linter/plugins): do not allow access to Context#id in createOnce
#15489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
Merge activity
|
…ce` (#15489) Revert #15447. It's easy to allow `Context#id` to be accessed in `createOnce` when running rule in Oxlint, but not possible to do in ESLint compat mode with current API, because `id` isn't a property of the rule, so `defineRule` doesn't know it. We could support it by making `definePlugin` compulsory for ESLint interop, and get it to set `id` property on `Context` objects properly. But that's a bit tricky, so just disable access for now. It's probably not very useful anyway - a rule should know what its own name is!
graphite-app
bot
force-pushed
the
11-08-fix_linter_plugins_allow_access_to_cwd_in_createonce_in_eslint_interop_mode
branch
from
ee9287b to
7409630
Compare
graphite-app
bot
force-pushed
the
11-08-fix_linter_plugins_do_not_allow_access_to_context_id_in_createonce_
branch
from
34bd693 to
6957fb9
Compare
Base automatically changed from
11-08-fix_linter_plugins_allow_access_to_cwd_in_createonce_in_eslint_interop_mode
to
main
November 8, 2025 14:52
graphite-app
bot
deleted the
11-08-fix_linter_plugins_do_not_allow_access_to_context_id_in_createonce_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #15447. It's easy to allow
Context#idto be accessed increateOncewhen running rule in Oxlint, but not possible to do in ESLint compat mode with current API, becauseidisn't a property of the rule, sodefineRuledoesn't know it.We could support it by making
definePlugincompulsory for ESLint interop, and get it to setidproperty onContextobjects properly.But that's a bit tricky, so just disable access for now. It's probably not very useful anyway - a rule should know what its own name is!