feat(formatter/sort_imports): Sort imports by Array<Array<string>> groups

[leaysgur]

Current implementation was performimg sort based on hard-coded enum.

This PR changed it to use group definitions like this.

[
  'type-import',
  ['value-builtin', 'value-external'],
  'type-internal',
  'value-internal',
  ['type-parent', 'type-sibling', 'type-index'],
  ['value-parent', 'value-sibling', 'value-index'],
  'ts-equals-import',
  'unknown',
]

https://perfectionist.dev/rules/sort-imports#groups

And this will be refactored in the subsequent 2 PRs.

[leaysgur]

• perf(formatter/sort_imports): Precompute import metadata #15580
• perf(formatter/sort_imports): Use Vec::with_capacity for next_elements #15579
• feat(formatter/sort_imports): Sort imports by Array<Array<string>> groups #15578 👈 (View in Graphite)
• test(formatter/sort_imports): Fix tests to match with original #15577
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #15578 will not alter performance

_{Comparing 11-11-feat_formatter_sort_imports_sort_imports_by_array_array_string_data (cf3f9cf) with main (fd58aea)}

Summary

✅ 33 untouched
⏩ 4 skipped¹

Footnotes

1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull Request Overview

This PR refactors the import sorting functionality to use configurable group definitions (Vec<Vec<String>>) instead of a hard-coded enum-based approach. The new system matches imports against group names like 'type-import', ['value-builtin', 'value-external'], etc., following the Perfectionist plugin convention. This enables more flexible import organization and sets the stage for user-configurable groups in future PRs.

Key changes:

• Replaced ImportGroup enum with dynamic group matching using Vec<Vec<String>>
• Implemented match_group() and generate_group_names() methods for flexible import categorization
• Added groups field to SortImports struct with a default_groups() factory method

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
crates/oxc_formatter/src/options.rs	Added groups field to SortImports struct and removed Copy and Hash derives; implemented default_groups() method
crates/oxc_formatter/src/ir_transform/sort_imports/import_unit.rs	Removed ImportGroup enum; added group matching logic with ImportSelector and ImportModifier enums
crates/oxc_formatter/src/ir_transform/sort_imports/mod.rs	Updated to pass groups by reference and use group index instead of group enum
crates/oxc_formatter/src/lib.rs	Changed to clone experimental_sort_imports since it's no longer Copy
crates/oxc_formatter/src/service/oxfmtrc.rs	Added TODO and default groups initialization
crates/oxc_formatter/examples/sort_imports.rs	Added groups field initialization and cloning
napi/playground/src/options.rs	Added documentation for experimental_sort_imports and new groups option
napi/playground/src/lib.rs	Added TODO and default groups initialization

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[graphite-app]

Merge activity

• Nov 11, 5:53 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Nov 11, 5:59 AM UTC: Merged by the Graphite merge queue.