feat(oxfmt): Print nothing for default(write) mode #15583

leaysgur · 2025-11-11T06:18:33Z

leaysgur · 2025-11-11T06:18:49Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR modifies the oxfmt formatter to make the default write mode completely silent. Previously, the default mode would output messages for each formatted file and statistics. Now it produces no output unless there are errors.

Removed diagnostic warnings for formatted files in default write mode
Removed the summary statistics that displayed "Formatted X files" and timing information
Updated documentation to clarify that Check mode shows statistics

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
apps/oxfmt/src/service.rs	Removes diagnostic warning emission for DefaultWrite mode when processing individual files
apps/oxfmt/src/format.rs	Removes the "Formatted X files" message and statistics output for DefaultWrite mode, adds assertion to verify no warnings in write mode
apps/oxfmt/src/command.rs	Updates the documentation comment for Check mode to clarify it shows statistics

Comments suppressed due to low confidence (1)

apps/oxfmt/src/format.rs:148

With the change to make DefaultWrite mode produce no output, this newline is now printed unconditionally even when using DefaultWrite mode (where no diagnostics are emitted). Consider only printing this newline when there were actually diagnostics printed, or when not in DefaultWrite mode, to avoid printing an unnecessary blank line in silent mode.

        print_and_flush_stdout(stdout, "\n");

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/oxfmt/src/format.rs

apps/oxfmt/src/service.rs

Dunqing · 2025-11-11T06:38:37Z

Merge activity

Nov 11, 6:38 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 11, 6:38 AM UTC: Dunqing added this pull request to the Graphite merge queue.
Nov 11, 6:44 AM UTC: Merged by the Graphite merge queue.

Fixes #15555

# Oxlint ### 🚀 Features - c199e38 linter: Implement config for all tsgolint rules supporting options (#15659) (camchenry) - 7598b3e linter: Allow configuring tsgolint rules (#15286) (camchenry) - e77f2ce vscode: Support `oxlint --lsp` (#15680) (Sysix) - e01c551 oxlint: Add `--lsp` flag to run the language server (#15611) (Sysix) - ac5c2ab lsp/fmt: Support ignore files & patterns (#15647) (Sysix) - e50a9bf linter: Add unicorn/prefer-response-static-json rule (#15692) (Mikhail Baev) - f5d9abb oxlint: Add enabled? column to --rules cli output (#15213) (Wren) - 6b5205c linter/plugins: Implement deprecated `SourceCode#getJSDocComment` method (#15653) (overlookmotel) - 5eccff1 linter/plugins: Implement deprecated `SourceCode` tokens methods (#15645) (overlookmotel) - 4c62ffa language_server: Add `run_server` helper for CLI tools (#15609) (Sysix) - 0d52a5e linter/plugins: Implement `Context#parserOptions` getter (#15632) (overlookmotel) - 287a538 linter/plugins: Implement `Context#get*` deprecated methods (#15606) (overlookmotel) - 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur) - e763919 linter: Add test to enforce schema documentation for rules with configuration options (#15234) (Connor Shea) - 6cd0b5f linter/no-callback-in-promise: Add support for `timeoutsErr` option (#15507) (Li Wei) ### 🐛 Bug Fixes - 1decd57 linter/no-empty-named-blocks: Only search within node for comma token (#15751) (camc314) - 17c3d6d linter: Improve docs, diagnostic message, and implementation of typescript/consistent-indexed-object-style rule. (#15750) (connorshea) - 78a6df2 linter/no-empty-named-blocks: Skip comments when searching for token (#15735) (camc314) - 042befd linter/require-await: Skip comments when searching for token (#15734) (camc314) - 7a78220 linter/no-async-await: Skip comments when searching for token (#15733) (camc314) - 23b9ad1 linter/consistent-type-specifier-style: Skip comments when searching for token (#15732) (camc314) - 440a977 ast: Include rest properties when using `get_binding_identifiers` (#15710) (camc314) - 516d14e linter/no-namespace: Skip comments when searching for token (#15716) (camc314) - b5aaace linter/prefer-namespace-keyword: Skip comments when searching for token (#15715) (camc314) - 4eb9fa6 editor: Execute `oxc.path.server` in win32 with shell (#14203) (Sysix) - 9f991a4 linter: Reverse extends overrides priority (#14939) (Peter Wagenet) - 7c4a916 linter: Restores `oxlint --rules -f=json` functionality. (#15689) (Wren) - 24d00f4 linter/plugins: Add types for suggested fixes (#15636) (overlookmotel) - 257360f linter/plugins: Fill in TS type def for `RuleMeta` (#15629) (overlookmotel) - 81e179c linter: Allow file extensions without a dot in react/jsx-filename-extension rule (#15574) (Connor Shea) - 7a0e931 linter: Update the unicorn/prefer-add-event-listener rule with new JavaScript APIs (#15581) (connorshea) - bb5f8ca oxlint: Fix type annotation for big-endian (#15561) (Sysix) ### ⚡ Performance - e2a0997 linter/plugins: Recycle empty visitor object in ESLint compat mode (#15693) (overlookmotel) - 7528db4 language_server: Pass file content as a referenced `String` (#15568) (Sysix) - 54061e9 linter/plugins: Avoid implicit boolean coercion in `initLines` (#15641) (overlookmotel) - ccfd935 language_server: Avoid `Mutex` in `ServerLinter` (#15516) (Sysix) ### 📚 Documentation - 3ab750a linter: Clarify react-in-jsx-scope rule docs. (#15749) (connorshea) - a5feebc linter: `oxlint-disable` not `eslint-disable` (#15672) (overlookmotel) - 3d15805 linter: Reformat doc comments (#15670) (overlookmotel) - 16fcba6 linter: Remove "experimental" from description of stable features (#15669) (overlookmotel) - e62fd98 linter: Correct comment on what `EnablePlugins` does (#15668) (overlookmotel) - a25d31e linter: Fix grammar (#15666) (overlookmotel) - f5f452f linter: Add missing `perf` category (#15667) (overlookmotel) - 2c58952 linter: Add config docs for no-restricted-globals rule. (#15662) (connorshea) - a210b12 linter/plugins: Improve JSDoc comment for `RuleOptionsSchema` (#15642) (overlookmotel) - 3aabfac linter/plugins: Alter comments on `FILE_CONTEXT` used in ESLint-compat `Context` shim (#15605) (overlookmotel) - fd58aea linter: Fix a typo in the docs for react/no-is-mounted. (#15575) (Connor Shea) # Oxfmt ### 🚀 Features - 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur) - 99823ad oxfmt: Print nothing for default(write) mode (#15583) (leaysgur) - 25a0163 formatter/sort_imports: Sort imports by `Array<Array<string>>` groups (#15578) (leaysgur) ### 🐛 Bug Fixes - bf20cf5 formatter: `CRLF` issue in the member chain (#15764) (Dunqing) - 5d688a0 formatter: Measuring multiline text in `fits_text` is incorrect (#15762) (Dunqing) - e306958 formatter: Regression case for test call (#15760) (Dunqing) - c42d983 formatter: Re-fix all cases that fail after `AstNode::Argument` was removed (#15676) (Dunqing) ### ⚡ Performance - d99a83f oxfmt: Use simdutf8 based read_to_string (#15614) (leaysgur) - 128e186 formatter/sort_imports: Precompute import metadata (#15580) (leaysgur) - cd31cc1 formatter/sort_imports: Use `Vec::with_capacity` for `next_elements` (#15579) (leaysgur) ### 📚 Documentation - 3d15805 linter: Reformat doc comments (#15670) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 11, 2025 06:18

github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request labels Nov 11, 2025

Copilot started reviewing on behalf of leaysgur November 11, 2025 06:18 View session

Copilot finished reviewing on behalf of leaysgur November 11, 2025 06:20

Copilot AI reviewed Nov 11, 2025

View reviewed changes

apps/oxfmt/src/format.rs Outdated Show resolved Hide resolved

Dunqing requested changes Nov 11, 2025

View reviewed changes

apps/oxfmt/src/service.rs Outdated Show resolved Hide resolved

leaysgur force-pushed the 11-11-feat_oxfmt_print_nothing_for_default_write_mode branch from 82a6f26 to 86c87ff Compare November 11, 2025 06:30

leaysgur requested a review from Dunqing November 11, 2025 06:31

leaysgur assigned Dunqing Nov 11, 2025

Dunqing approved these changes Nov 11, 2025

View reviewed changes

Dunqing added the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025

feat(oxfmt): Print nothing for default(write) mode (#15583)

99823ad

Fixes #15555

graphite-app bot force-pushed the 11-11-feat_oxfmt_print_nothing_for_default_write_mode branch from 86c87ff to 99823ad Compare November 11, 2025 06:39

leaysgur mentioned this pull request Nov 11, 2025

ci(benchmarks/formatter): Update formatter bench with sort-imports #15584

Merged

graphite-app bot merged commit 99823ad into main Nov 11, 2025
18 checks passed

graphite-app bot deleted the 11-11-feat_oxfmt_print_nothing_for_default_write_mode branch November 11, 2025 06:44

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025

Boshen mentioned this pull request Nov 17, 2025

release(apps): oxlint v1.29.0 && oxfmt v0.14.0 #15772

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(oxfmt): Print nothing for default(write) mode #15583

feat(oxfmt): Print nothing for default(write) mode #15583

leaysgur commented Nov 11, 2025 •

edited

Loading

Uh oh!

leaysgur commented Nov 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Dunqing commented Nov 11, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(oxfmt): Print nothing for default(write) mode #15583

feat(oxfmt): Print nothing for default(write) mode #15583

Conversation

leaysgur commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaysgur commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Dunqing commented Nov 11, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leaysgur commented Nov 11, 2025 •

edited

Loading

leaysgur commented Nov 11, 2025 •

edited

Loading

Dunqing commented Nov 11, 2025 •

edited by graphite-app bot

Loading