Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 11, 2025

Update oxfmt config so it formats apps/oxlint/test/fixtures.

Actual formatting changes were in PRs #15600 and #15674. This PR alters the config so all these files will continue to be formatted in future.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 11, 2025
Copy link
Member Author

overlookmotel commented Nov 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel added the A-linter-plugins Area - Linter JS plugins label Nov 11, 2025
@overlookmotel overlookmotel self-assigned this Nov 11, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 11, 2025 15:55
@graphite-app graphite-app bot changed the base branch from 11-11-style_oxlint_plugins_format_test_fixtures to graphite-base/15601 November 11, 2025 15:56
@graphite-app graphite-app bot force-pushed the graphite-base/15601 branch from 65e1478 to aee9be1 Compare November 11, 2025 16:03
@graphite-app graphite-app bot force-pushed the 11-11-style_linter_plugins_update_oxfmt_config_to_format_oxlint_fixtures branch from 9ce7efe to 2fa4340 Compare November 11, 2025 16:03
@graphite-app graphite-app bot changed the base branch from graphite-base/15601 to main November 11, 2025 16:04
@graphite-app graphite-app bot force-pushed the 11-11-style_linter_plugins_update_oxfmt_config_to_format_oxlint_fixtures branch from 2fa4340 to cb08016 Compare November 11, 2025 16:04
@overlookmotel overlookmotel changed the base branch from main to graphite-base/15601 November 11, 2025 16:36
@overlookmotel overlookmotel force-pushed the 11-11-style_linter_plugins_update_oxfmt_config_to_format_oxlint_fixtures branch from cb08016 to 3dc1640 Compare November 11, 2025 16:36
@overlookmotel overlookmotel changed the base branch from graphite-base/15601 to 11-11-style_linter_plugins_use_prettier-ignore_in_test_fixtures November 11, 2025 16:36
@graphite-app graphite-app bot changed the base branch from 11-11-style_linter_plugins_use_prettier-ignore_in_test_fixtures to graphite-base/15601 November 11, 2025 16:42
@graphite-app graphite-app bot force-pushed the graphite-base/15601 branch from eb1a844 to 74033bd Compare November 11, 2025 16:49
@graphite-app graphite-app bot force-pushed the 11-11-style_linter_plugins_update_oxfmt_config_to_format_oxlint_fixtures branch from 3dc1640 to ddfde55 Compare November 11, 2025 16:49
@graphite-app graphite-app bot changed the base branch from graphite-base/15601 to main November 11, 2025 16:49
@graphite-app graphite-app bot force-pushed the 11-11-style_linter_plugins_update_oxfmt_config_to_format_oxlint_fixtures branch from ddfde55 to 7828f32 Compare November 11, 2025 16:50
Copy link
Member

@leaysgur leaysgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #15600, you want to format

  • apps/oxlint/test/fixtures

right?

In case of that, this seems to work.

diff --git a/oxfmtrc.jsonc b/oxfmtrc.jsonc
index 36bdccee3..07e96aa2a 100644
--- a/oxfmtrc.jsonc
+++ b/oxfmtrc.jsonc
@@ -7,6 +7,7 @@
     "**/tests/**",
     "**/generated/**",
     "**/fixtures/**",
+    "!apps/oxlint/test/fixtures/**",
     "tasks/coverage/node-compat-table",
     "tasks/coverage/misc",
     "tasks/coverage/src/runtime/babelHelpers.js",

What you were trying in your opening comment appears:

{
  "ignorePatterns": [
    "**/fixtures/**",
    "!apps/oxlint/fixtures/**",
  ]
}
  • apps/oxlint/fixtures

should be

  • apps/oxlint/test/fixtures

@overlookmotel overlookmotel changed the base branch from main to graphite-base/15601 November 13, 2025 14:41
@overlookmotel overlookmotel force-pushed the 11-11-style_linter_plugins_update_oxfmt_config_to_format_oxlint_fixtures branch from 7828f32 to 4995e79 Compare November 13, 2025 14:41
@overlookmotel overlookmotel changed the base branch from graphite-base/15601 to 11-13-test_linter_plugins_prevent_test_fixture_getting_formatted November 13, 2025 14:41
@overlookmotel
Copy link
Member Author

overlookmotel commented Nov 13, 2025

Oh, I'm a total idiot! Thanks very much for pointing out my error.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2025
Copy link
Member Author

overlookmotel commented Nov 13, 2025

Merge activity

@overlookmotel overlookmotel removed the request for review from Dunqing November 13, 2025 14:49
overlookmotel added a commit that referenced this pull request Nov 13, 2025
Add `// prettier-ignore` comment to test fixture, to prevent it getting
formatted once #15601 is merged.
Base automatically changed from 11-13-test_linter_plugins_prevent_test_fixture_getting_formatted to main November 13, 2025 15:09
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Nov 13, 2025
graphite-app bot pushed a commit that referenced this pull request Nov 13, 2025
…res (#15601)

Update `oxfmt` config so it formats `apps/oxlint/test/fixtures`.

Actual formatting changes were in PRs #15600 and #15674. This PR alters the config so all these files will continue to be formatted in future.
@graphite-app graphite-app bot force-pushed the 11-11-style_linter_plugins_update_oxfmt_config_to_format_oxlint_fixtures branch from 4995e79 to 709e4e4 Compare November 13, 2025 15:10
@overlookmotel overlookmotel force-pushed the 11-11-style_linter_plugins_update_oxfmt_config_to_format_oxlint_fixtures branch from 709e4e4 to 862daf4 Compare November 13, 2025 15:11
@overlookmotel overlookmotel removed the A-linter Area - Linter label Nov 13, 2025
…res (#15601)

Update `oxfmt` config so it formats `apps/oxlint/test/fixtures`.

Actual formatting changes were in PRs #15600 and #15674. This PR alters the config so all these files will continue to be formatted in future.
@graphite-app graphite-app bot force-pushed the 11-11-style_linter_plugins_update_oxfmt_config_to_format_oxlint_fixtures branch from 862daf4 to 6ce62c5 Compare November 13, 2025 15:12
@graphite-app graphite-app bot merged commit 6ce62c5 into main Nov 13, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-11-style_linter_plugins_update_oxfmt_config_to_format_oxlint_fixtures branch November 13, 2025 15:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants