-
-
Notifications
You must be signed in to change notification settings - Fork 728
style(linter/plugins): update oxfmt config to format oxlint fixtures
#15601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(linter/plugins): update oxfmt config to format oxlint fixtures
#15601
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
65e1478 to
aee9be1
Compare
9ce7efe to
2fa4340
Compare
2fa4340 to
cb08016
Compare
cb08016 to
3dc1640
Compare
eb1a844 to
74033bd
Compare
3dc1640 to
ddfde55
Compare
ddfde55 to
7828f32
Compare
leaysgur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to #15600, you want to format
apps/oxlint/test/fixtures
right?
In case of that, this seems to work.
diff --git a/oxfmtrc.jsonc b/oxfmtrc.jsonc
index 36bdccee3..07e96aa2a 100644
--- a/oxfmtrc.jsonc
+++ b/oxfmtrc.jsonc
@@ -7,6 +7,7 @@
"**/tests/**",
"**/generated/**",
"**/fixtures/**",
+ "!apps/oxlint/test/fixtures/**",
"tasks/coverage/node-compat-table",
"tasks/coverage/misc",
"tasks/coverage/src/runtime/babelHelpers.js",
What you were trying in your opening comment appears:
{
"ignorePatterns": [
"**/fixtures/**",
"!apps/oxlint/fixtures/**",
]
}apps/oxlint/fixtures
should be
apps/oxlint/test/fixtures
7828f32 to
4995e79
Compare
|
Oh, I'm a total idiot! Thanks very much for pointing out my error. |
Merge activity
|
Add `// prettier-ignore` comment to test fixture, to prevent it getting formatted once #15601 is merged.
4995e79 to
709e4e4
Compare
709e4e4 to
862daf4
Compare
862daf4 to
6ce62c5
Compare

Update
oxfmtconfig so it formatsapps/oxlint/test/fixtures.Actual formatting changes were in PRs #15600 and #15674. This PR alters the config so all these files will continue to be formatted in future.