feat(lsp/fmt): support ignore files & patterns #15647

Sysix · 2025-11-12T21:17:06Z

This PR adds support for ignore files (.gitignore, .prettierignore) and ignore patterns (ignorePatterns in config) to the language server formatter

The server does not support a custom ignore path, it is the same for the server linter and its CLI integration too :)

Sysix · 2025-11-12T21:17:26Z

feat(lsp/fmt): support ignore files & patterns #15647 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR adds support for ignore files (.gitignore, .prettierignore) and ignore patterns (ignorePatterns in config) to the language server formatter, addressing issue #15459. The feature is only active when the experimental formatter is enabled.

Key changes:

Refactored configuration loading to extract ignore patterns before converting to FormatOptions
Implemented create_ignore_globs to build ignore matchers from files and config patterns
Added is_ignored check in the formatting flow to skip ignored files
Added comprehensive tests with fixtures for both ignore files and patterns

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`crates/oxc_language_server/src/formatter/server_formatter.rs`	Core implementation: refactored config loading, added ignore glob creation, file ignore checking, and helper function for loading ignore file paths
`crates/oxc_language_server/fixtures/formatter/ignore-file/.prettierignore`	Test fixture: ignore file that excludes `*.ts` files
`crates/oxc_language_server/fixtures/formatter/ignore-file/.oxfmtrc.json`	Test fixture: config file with `semi: false` for ignore file tests
`crates/oxc_language_server/fixtures/formatter/ignore-file/ignored.ts`	Test fixture: TypeScript file that should be ignored by `.prettierignore`
`crates/oxc_language_server/fixtures/formatter/ignore-file/not-ignored.js`	Test fixture: JavaScript file that should be formatted
`crates/oxc_language_server/fixtures/formatter/ignore-pattern/.oxfmtrc.json`	Test fixture: config file with `ignorePatterns: ["*.ts"]`
`crates/oxc_language_server/fixtures/formatter/ignore-pattern/ignored.ts`	Test fixture: TypeScript file that should be ignored by pattern
`crates/oxc_language_server/fixtures/formatter/ignore-pattern/not-ignored.js`	Test fixture: JavaScript file that should be formatted
`crates/oxc_language_server/src/formatter/snapshots/fixtures_formatter_ignore-file@ignored.ts_not-ignored.js.snap`	Test snapshot: expected output showing ignored.ts is ignored and not-ignored.js gets formatted
`crates/oxc_language_server/src/formatter/snapshots/fixtures_formatter_ignore-pattern@ignored.ts_not-ignored.js.snap`	Test snapshot: expected output showing pattern-based ignoring works correctly

Comments suppressed due to low confidence (1)

crates/oxc_language_server/src/formatter/server_formatter.rs:361

The comment says "does not handle custom ignore files" but it's unclear what "custom ignore files" means in this context. Consider clarifying this to explain that unlike oxfmt::walk::load_ignore_paths, this version doesn't accept a user-provided list of ignore file paths as a parameter.

    let start = prefix_byte as u32;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_language_server/src/formatter/server_formatter.rs

leaysgur

(I'm not familiar with LS but, ) looks good to me.

camc314 · 2025-11-14T11:27:09Z

Merge activity

Nov 14, 11:27 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 14, 11:27 AM UTC: camc314 added this pull request to the Graphite merge queue.
Nov 14, 11:36 AM UTC: Merged by the Graphite merge queue.

closes #15459 > This PR adds support for ignore files (.gitignore, .prettierignore) and ignore patterns (ignorePatterns in config) to the language server formatter The server does not support a custom ignore path, it is the same for the server linter and its CLI integration too :)

# Oxlint ### 🚀 Features - c199e38 linter: Implement config for all tsgolint rules supporting options (#15659) (camchenry) - 7598b3e linter: Allow configuring tsgolint rules (#15286) (camchenry) - e77f2ce vscode: Support `oxlint --lsp` (#15680) (Sysix) - e01c551 oxlint: Add `--lsp` flag to run the language server (#15611) (Sysix) - ac5c2ab lsp/fmt: Support ignore files & patterns (#15647) (Sysix) - e50a9bf linter: Add unicorn/prefer-response-static-json rule (#15692) (Mikhail Baev) - f5d9abb oxlint: Add enabled? column to --rules cli output (#15213) (Wren) - 6b5205c linter/plugins: Implement deprecated `SourceCode#getJSDocComment` method (#15653) (overlookmotel) - 5eccff1 linter/plugins: Implement deprecated `SourceCode` tokens methods (#15645) (overlookmotel) - 4c62ffa language_server: Add `run_server` helper for CLI tools (#15609) (Sysix) - 0d52a5e linter/plugins: Implement `Context#parserOptions` getter (#15632) (overlookmotel) - 287a538 linter/plugins: Implement `Context#get*` deprecated methods (#15606) (overlookmotel) - 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur) - e763919 linter: Add test to enforce schema documentation for rules with configuration options (#15234) (Connor Shea) - 6cd0b5f linter/no-callback-in-promise: Add support for `timeoutsErr` option (#15507) (Li Wei) ### 🐛 Bug Fixes - 1decd57 linter/no-empty-named-blocks: Only search within node for comma token (#15751) (camc314) - 17c3d6d linter: Improve docs, diagnostic message, and implementation of typescript/consistent-indexed-object-style rule. (#15750) (connorshea) - 78a6df2 linter/no-empty-named-blocks: Skip comments when searching for token (#15735) (camc314) - 042befd linter/require-await: Skip comments when searching for token (#15734) (camc314) - 7a78220 linter/no-async-await: Skip comments when searching for token (#15733) (camc314) - 23b9ad1 linter/consistent-type-specifier-style: Skip comments when searching for token (#15732) (camc314) - 440a977 ast: Include rest properties when using `get_binding_identifiers` (#15710) (camc314) - 516d14e linter/no-namespace: Skip comments when searching for token (#15716) (camc314) - b5aaace linter/prefer-namespace-keyword: Skip comments when searching for token (#15715) (camc314) - 4eb9fa6 editor: Execute `oxc.path.server` in win32 with shell (#14203) (Sysix) - 9f991a4 linter: Reverse extends overrides priority (#14939) (Peter Wagenet) - 7c4a916 linter: Restores `oxlint --rules -f=json` functionality. (#15689) (Wren) - 24d00f4 linter/plugins: Add types for suggested fixes (#15636) (overlookmotel) - 257360f linter/plugins: Fill in TS type def for `RuleMeta` (#15629) (overlookmotel) - 81e179c linter: Allow file extensions without a dot in react/jsx-filename-extension rule (#15574) (Connor Shea) - 7a0e931 linter: Update the unicorn/prefer-add-event-listener rule with new JavaScript APIs (#15581) (connorshea) - bb5f8ca oxlint: Fix type annotation for big-endian (#15561) (Sysix) ### ⚡ Performance - e2a0997 linter/plugins: Recycle empty visitor object in ESLint compat mode (#15693) (overlookmotel) - 7528db4 language_server: Pass file content as a referenced `String` (#15568) (Sysix) - 54061e9 linter/plugins: Avoid implicit boolean coercion in `initLines` (#15641) (overlookmotel) - ccfd935 language_server: Avoid `Mutex` in `ServerLinter` (#15516) (Sysix) ### 📚 Documentation - 3ab750a linter: Clarify react-in-jsx-scope rule docs. (#15749) (connorshea) - a5feebc linter: `oxlint-disable` not `eslint-disable` (#15672) (overlookmotel) - 3d15805 linter: Reformat doc comments (#15670) (overlookmotel) - 16fcba6 linter: Remove "experimental" from description of stable features (#15669) (overlookmotel) - e62fd98 linter: Correct comment on what `EnablePlugins` does (#15668) (overlookmotel) - a25d31e linter: Fix grammar (#15666) (overlookmotel) - f5f452f linter: Add missing `perf` category (#15667) (overlookmotel) - 2c58952 linter: Add config docs for no-restricted-globals rule. (#15662) (connorshea) - a210b12 linter/plugins: Improve JSDoc comment for `RuleOptionsSchema` (#15642) (overlookmotel) - 3aabfac linter/plugins: Alter comments on `FILE_CONTEXT` used in ESLint-compat `Context` shim (#15605) (overlookmotel) - fd58aea linter: Fix a typo in the docs for react/no-is-mounted. (#15575) (Connor Shea) # Oxfmt ### 🚀 Features - 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur) - 99823ad oxfmt: Print nothing for default(write) mode (#15583) (leaysgur) - 25a0163 formatter/sort_imports: Sort imports by `Array<Array<string>>` groups (#15578) (leaysgur) ### 🐛 Bug Fixes - bf20cf5 formatter: `CRLF` issue in the member chain (#15764) (Dunqing) - 5d688a0 formatter: Measuring multiline text in `fits_text` is incorrect (#15762) (Dunqing) - e306958 formatter: Regression case for test call (#15760) (Dunqing) - c42d983 formatter: Re-fix all cases that fail after `AstNode::Argument` was removed (#15676) (Dunqing) ### ⚡ Performance - d99a83f oxfmt: Use simdutf8 based read_to_string (#15614) (leaysgur) - 128e186 formatter/sort_imports: Precompute import metadata (#15580) (leaysgur) - cd31cc1 formatter/sort_imports: Use `Vec::with_capacity` for `next_elements` (#15579) (leaysgur) ### 📚 Documentation - 3d15805 linter: Reformat doc comments (#15670) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-cli Area - CLI A-editor Area - Editor and Language Server A-formatter Area - Formatter C-enhancement Category - New feature or request labels Nov 12, 2025

Sysix force-pushed the 11-12-feat_lsp_fmt_support_ignore_files branch 2 times, most recently from d626616 to 603595a Compare November 13, 2025 18:38

Sysix changed the title ~~feat(lsp/fmt): support ignore files~~ feat(lsp/fmt): support ignore files & patterns Nov 13, 2025

Sysix requested a review from Copilot November 13, 2025 18:39

Copilot started reviewing on behalf of Sysix November 13, 2025 18:40 View session

Sysix force-pushed the 11-12-feat_lsp_fmt_support_ignore_files branch from 603595a to 5eca275 Compare November 13, 2025 18:42

Copilot finished reviewing on behalf of Sysix November 13, 2025 18:45

Copilot AI reviewed Nov 13, 2025

View reviewed changes

Sysix force-pushed the 11-12-feat_lsp_fmt_support_ignore_files branch from 5eca275 to 2e5732d Compare November 13, 2025 18:50

Sysix marked this pull request as ready for review November 13, 2025 18:52

Sysix requested a review from camc314 as a code owner November 13, 2025 18:52

Sysix requested a review from leaysgur November 13, 2025 18:53

leaysgur approved these changes Nov 13, 2025

View reviewed changes

leaysgur assigned camc314 Nov 13, 2025

camc314 approved these changes Nov 14, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 14, 2025

graphite-app bot force-pushed the 11-12-feat_lsp_fmt_support_ignore_files branch from 2e5732d to ac5c2ab Compare November 14, 2025 11:31

graphite-app bot merged commit ac5c2ab into main Nov 14, 2025
21 checks passed

graphite-app bot deleted the 11-12-feat_lsp_fmt_support_ignore_files branch November 14, 2025 11:36

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 14, 2025

Boshen mentioned this pull request Nov 17, 2025

release(apps): oxlint v1.29.0 && oxfmt v0.14.0 #15772

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(lsp/fmt): support ignore files & patterns #15647

feat(lsp/fmt): support ignore files & patterns #15647

Uh oh!

Sysix commented Nov 12, 2025 •

edited

Loading

Uh oh!

Sysix commented Nov 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leaysgur left a comment

Uh oh!

camc314 commented Nov 14, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

feat(lsp/fmt): support ignore files & patterns #15647

feat(lsp/fmt): support ignore files & patterns #15647

Uh oh!

Conversation

Sysix commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Nov 12, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leaysgur left a comment

Choose a reason for hiding this comment

Uh oh!

camc314 commented Nov 14, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sysix commented Nov 12, 2025 •

edited

Loading

camc314 commented Nov 14, 2025 •

edited by graphite-app bot

Loading