fix(linter/exhaustive-dependencies): prevent is_callee_of_call_expr flag from leaking into nested expressions #15832

camc314 · 2025-11-18T09:09:53Z

No description provided.

camc314 · 2025-11-18T09:10:11Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-11-18T09:15:26Z

CodSpeed Performance Report

Merging #15832 will not alter performance

_{Comparing c/11-18-fix_linter_exhaustive-dependencies_prevent_is_callee_of_call_expr_flag_from_leaking_into_nested_expressions (953e0c3) with main (2191ae9)}

Summary

✅ 4 untouched
⏩ 41 skipped¹

41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314 · 2025-11-18T09:26:50Z

Merge activity

Nov 18, 9:26 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 18, 9:31 AM UTC: camc314 added this pull request to the Graphite merge queue.
Nov 18, 9:36 AM UTC: Merged by the Graphite merge queue.

Copilot

Pull Request Overview

This PR fixes a bug in the exhaustive-dependencies linter where the is_callee_of_call_expr flag was leaking into nested expressions during AST traversal. The fix ensures that when recursively visiting member expression objects, the flag is properly reset to prevent incorrect dependency analysis.

Key Changes

Reset is_callee_of_call_expr flag to false before visiting nested objects in static member expressions
Restructured code from match to if let for better readability
Added comprehensive test cases for property access within expressions followed by method calls

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/oxc_linter/src/rules/react/exhaustive_deps.rs	Fixed flag leak by resetting `is_callee_of_call_expr` before recursive visits; added test cases for nested property access in expressions
crates/oxc_linter/src/snapshots/react_exhaustive_deps.snap	Updated snapshot to reflect correct detection of multiple dependency levels in property chains

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…lag from leaking into nested expressions (#15832)

# Oxlint ### 💥 BREAKING CHANGES - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (#15712) (overlookmotel) ### 🚀 Features - 72660f7 linter: Support auto generate config document for tuple lint option (#15904) (Duc Nghiem Xuan) - 0c1f82b linter/plugins: Add `tokens` property to `Program` (#16020) (overlookmotel) - 9e61beb linter/plugins: Implement `SourceCode#getFirstToken()` (#16002) (Arsh) - 9a548dd linter/plugins: Implement `SourceCode#getLastTokens()` (#16000) (Arsh) - 0b6cb11 linter/plugins: Implement `SourceCode#getFirstTokens()` (#15976) (Arsh) - 166781e linter/plugins: Implement `SourceCode#getTokenAfter()` (#15973) (Arsh) - 6ae232b linter: Expose type errors via tsgolint (#15917) (camc314) - 2bfdd26 linter/plugins: Implement `SourceCode#getTokensAfter()` (#15971) (Arsh) - 45fffc1 linter/plugins: Implement `SourceCode#getTokenBefore()` (#15956) (Arsh) - 776e473 linter/plugins: Implement `SourceCode#getTokensBefore()` (#15955) (Arsh) - 595867a oxlint: Generate markdownDescription fields for oxlint JSON schema. (#15959) (connorshea) - 5569317 vscode: Add quick actions to status bar tooltip (#15962) (Sysix) - 986cac1 linter/plugins: Token-related `SourceCode` APIs (TS ESLint implementation) (#15861) (Arsh) - a21f9e4 linter: Implement unicorn/prefer-bigint-literals rule (#15923) (Michiel Vrins) - 4b9d8d2 linter/type-aware: Include range with tsconfig diagnostics (#15916) (camc314) - 220d01e editor: Improve the status bar item for the VS Code extension by adding a tooltip. (#15819) (connorshea) ### 🐛 Bug Fixes - 2bd3cb6 apps, editors, napi: Fix `oxlint-disable` comments (#16014) (overlookmotel) - 81f5360 linter/prefer-number-properties: Get fixer to replace entire call expr (#15979) (camc314) - e4ba07f language_server: Always write to memory file system (#15975) (Sysix) - a8a2032 linter: Support missing `range` for internal diagnostics (#15964) (camc314) - 619a226 oxlint/lsp: Don't register `textDocument/formatting` capability (#15882) (Sysix) - 6ab1a20 linter: Fix no_useless_spread producing invalid syntax when removing empty object spreads (#15905) (camc314) - be4b6df linter: Unicorn/prefer-string-replace-all incorrectly escapes backslashes (#15901) (camc314) - 9fa9ef2 linter: Gracefully fail when using import plugin, large file counf and JS plugins (#15864) (camc314) - c027398 linter/plugins: Correct bindings package names glob in TSDown config (#15871) (overlookmotel) - b622ef8 linter: Fix `oxc/bad_array_method_on_arguments` rule behavior. (#15854) (connorshea) - aa06c3f linter: Recognize NewExpression as value context in no-unused-private-class-members (#15843) (camc314) - e89c5ba typescript/prefer-namespace-keyword: Skip nested `TSModuleDeclaration`s (#15806) (overlookmotel) - 646d020 linter/exhaustive-dependencies: Prevent is_callee_of_call_expr flag from leaking into nested expressions (#15832) (camc314) - 46bd6bd linter/plugins: Pin `@typescript-eslint/scope-manager` dependency (#15807) (overlookmotel) - fba31fa linter: Patch `@typescript-eslint/scope manager` (#15214) (Arsh) - 50307c1 linter/jest: Ignore `expect` identifier in argument position (#15785) (camc314) ### ⚡ Performance - 024b48a linter/plugins: Lazy-load tokens parsing code (#16011) (overlookmotel) - 15365c9 linter/plugins: Reduce var assignments (#15953) (overlookmotel) - 84d1f4f linter/plugins: Downgrade some checks to debug-only (#15922) (overlookmotel) - a49f704 linter/typescript: Avoid searching source text unless required (#15805) (overlookmotel) ### 📚 Documentation - ceffa5a linter: Add config option docs for various rules. (#16024) (connorshea) - 9a0ed13 linter: Fix config option docs for eslint/operator-assignment rule. (#16030) (connorshea) - 0b18005 linter: Add config docs generation for rules with Regex arguments (#15978) (connorshea) - 48d18e0 linter: Improve diagnostic message for promise/catch-or-return rule (#15980) (connorshea) - 6c72e84 linter: Use backticks for code elements across more rule diagnostics (#15958) (connorshea) - a63dad7 linter/plugins: Add comment (#15952) (overlookmotel) - 81ea642 vscode: Use markdownDescription for better formatting in VSCode Settings (#15889) (connorshea) - db6a110 linter/plugins: Fix JSDoc comment (#15884) (overlookmotel) - 1487271 linter: Add config option docs for `jsdoc/require-param` and `jsdoc/require-returns` rules (#15857) (connorshea) - fbf0fd4 linter/plugins: Add JSDoc comments to `Plugin` and `Rule` types (#15815) (overlookmotel) - ac5e4b5 linter/plugins: Add JSDoc comments and improve comments (#15814) (overlookmotel) - 9b7b083 linter: Fix error in `curly` `"all"` example (#15801) (camc314) - 65a3520 linter: Improve diagnostic for consistent-type-definitions rule. (#15752) (connorshea) ### 🛡️ Security - f9b9276 deps: Update dependency rolldown to v1.0.0-beta.51 (#15856) (renovate[bot]) # Oxfmt ### 💥 BREAKING CHANGES - a937890 formatter: [**BREAKING**] Default to `lineWidth: 100` (#15933) (leaysgur) - 03d5f5a formatter/sort-imports: [**BREAKING**] Change default order to `natural` with `natord` crate (#15828) (leaysgur) - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (#15712) (overlookmotel) ### 🚀 Features - 7818e22 formatter/sort-imports: Support `options.groups` (#15831) (leaysgur) - f9a502c oxfmt: `oxfmt --lsp` support (#15765) (leaysgur) ### 🐛 Bug Fixes - 4817486 formatter: Revert `FormatElement::BestFitting` printing logic (#16028) (Dunqing) - 5562dd6 formatter: Incorrect formatting method chain with trailing comments (#16027) (Dunqing) - 6d14c8b formatter: Comments in export class decorators are printing incorrectly (#15897) (Dunqing) - 683c764 formatter: Correct a few minor mismatched typescript tests (#15894) (Dunqing) - c11cc07 formatter: Improve formatting for default type on type parameters (#15893) (Dunqing) - 0bff596 formatter: Handle JSX expresssion dangling comment (#15890) (leaysgur) - 16a9dc8 formatter: Inconsistent printing of class extends and interface extends (#15892) (Dunqing) - 300b496 formatter: Inconsistent CallExpression and NewExpression around member chain and logical expression (#15858) (Dunqing) ### ⚡ Performance - 65174cc formatter: Reduce the size of `TextWidth` to 4 byte (#15827) (Dunqing) - 4fe3aac formatter: Use `ArenaVec` and `ArenaBox` (#15420) (Dunqing) Co-authored-by: overlookmotel <557937+overlookmotel@users.noreply.github.com>

camc314 marked this pull request as ready for review November 18, 2025 09:10

github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Nov 18, 2025

camc314 mentioned this pull request Nov 18, 2025

feat(allocator): optimize memory usage with dual allocator pools for import plugin #15802

Closed

camc314 changed the base branch from c/11-17-feat_allocator_optimize_memory_usage_with_dual_allocator_pools_for_import_plugin to graphite-base/15832 November 18, 2025 09:10

camc314 force-pushed the c/11-18-fix_linter_exhaustive-dependencies_prevent_is_callee_of_call_expr_flag_from_leaking_into_nested_expressions branch from 1005264 to f6347f0 Compare November 18, 2025 09:10

camc314 force-pushed the graphite-base/15832 branch from 66f5d6b to 32f4fdd Compare November 18, 2025 09:10

camc314 changed the base branch from graphite-base/15832 to main November 18, 2025 09:10

Copilot AI review requested due to automatic review settings November 18, 2025 09:26

camc314 force-pushed the c/11-18-fix_linter_exhaustive-dependencies_prevent_is_callee_of_call_expr_flag_from_leaking_into_nested_expressions branch from f6347f0 to 953e0c3 Compare November 18, 2025 09:26

camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 18, 2025

Copilot started reviewing on behalf of camc314 November 18, 2025 09:26 View session

Copilot finished reviewing on behalf of camc314 November 18, 2025 09:29

Copilot AI reviewed Nov 18, 2025

View reviewed changes

fix(linter/exhaustive-dependencies): prevent is_callee_of_call_expr f…

646d020

…lag from leaking into nested expressions (#15832)

graphite-app bot force-pushed the c/11-18-fix_linter_exhaustive-dependencies_prevent_is_callee_of_call_expr_flag_from_leaking_into_nested_expressions branch from 953e0c3 to 646d020 Compare November 18, 2025 09:31

graphite-app bot merged commit 646d020 into main Nov 18, 2025
20 checks passed

graphite-app bot deleted the c/11-18-fix_linter_exhaustive-dependencies_prevent_is_callee_of_call_expr_flag_from_leaking_into_nested_expressions branch November 18, 2025 09:36

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 18, 2025

camc314 mentioned this pull request Nov 18, 2025

linter: exhaustive-deps now requires full object to be defined in the dependency array #15796

Closed

This was referenced Nov 24, 2025

release(apps): oxlint v1.30.0 && oxfmt v0.15.0 #16039

Closed

release(apps): oxlint v1.30.0 && oxfmt v0.15.0 #16047

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(linter/exhaustive-dependencies): prevent is_callee_of_call_expr flag from leaking into nested expressions #15832

fix(linter/exhaustive-dependencies): prevent is_callee_of_call_expr flag from leaking into nested expressions #15832

camc314 commented Nov 18, 2025

Uh oh!

camc314 commented Nov 18, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Nov 18, 2025 •

edited

Loading

Uh oh!

camc314 commented Nov 18, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(linter/exhaustive-dependencies): prevent is_callee_of_call_expr flag from leaking into nested expressions #15832

fix(linter/exhaustive-dependencies): prevent is_callee_of_call_expr flag from leaking into nested expressions #15832

Conversation

camc314 commented Nov 18, 2025

Uh oh!

camc314 commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #15832 will not alter performance

Summary

Footnotes

Uh oh!

camc314 commented Nov 18, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Nov 18, 2025 •

edited

Loading

codspeed-hq bot commented Nov 18, 2025 •

edited

Loading

camc314 commented Nov 18, 2025 •

edited by graphite-app bot

Loading