feat(formatter)!: Default to `lineWidth: 100` #15933

leaysgur · 2025-11-21T04:24:09Z

Fixes #15900

Update default 80 > 100
Set printWidth: 80 for fixture tests
- Test diffs are all just adding header part for used options
Also use printWidth: 80 for prettier_conformance

leaysgur · 2025-11-21T04:24:26Z

test(formatter): Test default printWidth as well #15934
feat(formatter)!: Default to lineWidth: 100 #15933 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR changes the default line width (print width) for the formatter from 80 to 100 characters, aligning with modern development practices while maintaining backward compatibility with Prettier for conformance testing.

Key Changes:

Default LineWidth changed from 80 to 100 in FormatOptions
Test infrastructure updated to explicitly use 80 for Prettier compatibility
All documentation and configuration schemas updated to reflect new default

Reviewed Changes

Copilot reviewed 77 out of 77 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`crates/oxc_formatter/src/options.rs`	Changed `LineWidth::default()` from 80 to 100 and updated documentation
`crates/oxc_formatter/src/service/oxfmtrc.rs`	Updated documentation comments and test assertions for new default
`npm/oxfmt/configuration_schema.json`	Updated JSON schema description to reflect default: 100
`crates/oxc_formatter/tests/snapshots/schema_json.snap`	Updated snapshot for schema changes
`tasks/prettier_conformance/src/spec.rs`	Explicitly sets printWidth to 80 for Prettier conformance tests
`crates/oxc_formatter/tests/fixtures/mod.rs`	Forces printWidth: 80 in all snapshot tests for Prettier compatibility
`crates/oxc_formatter/tests/fixtures/*/.snap`	Regenerated snapshots with printWidth: 80 annotation headers
`crates/oxc_formatter/src/formatter/printer/mod.rs`	Updated unit tests to accommodate 100-character default line width

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codspeed-hq · 2025-11-21T04:33:07Z

CodSpeed Performance Report

Merging #15933 will not alter performance

_{Comparing 11-21-feat_formatter_default_linewidth_100 (4fd71ed) with main (4b9d8d2)}

Summary

✅ 38 untouched
⏩ 7 skipped¹

7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

crates/oxc_formatter/tests/fixtures/mod.rs

graphite-app · 2025-11-21T07:02:07Z

Merge activity

Nov 21, 7:02 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Nov 21, 7:08 AM UTC: Merged by the Graphite merge queue.

Fixes #15900 - Update default 80 > 100 - Set `printWidth: 80` for fixture tests - Test diffs are all just adding header part for used options - Also use `printWidth: 80` for `prettier_conformance`

Follow up #15933 - Also tests with default `printWidth` - Refactored options printing for snapshot

Fixes #15900 - Update default 80 > 100 - Set `printWidth: 80` for fixture tests - Test diffs are all just adding header part for used options - Also use `printWidth: 80` for `prettier_conformance`

Follow up #15933 - Also tests with default `printWidth` - Refactored options printing for snapshot

# Oxlint ### 💥 BREAKING CHANGES - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (oxc-project#15712) (overlookmotel) ### 🚀 Features - 72660f7 linter: Support auto generate config document for tuple lint option (oxc-project#15904) (Duc Nghiem Xuan) - 0c1f82b linter/plugins: Add `tokens` property to `Program` (oxc-project#16020) (overlookmotel) - 9e61beb linter/plugins: Implement `SourceCode#getFirstToken()` (oxc-project#16002) (Arsh) - 9a548dd linter/plugins: Implement `SourceCode#getLastTokens()` (oxc-project#16000) (Arsh) - 0b6cb11 linter/plugins: Implement `SourceCode#getFirstTokens()` (oxc-project#15976) (Arsh) - 166781e linter/plugins: Implement `SourceCode#getTokenAfter()` (oxc-project#15973) (Arsh) - 6ae232b linter: Expose type errors via tsgolint (oxc-project#15917) (camc314) - 2bfdd26 linter/plugins: Implement `SourceCode#getTokensAfter()` (oxc-project#15971) (Arsh) - 45fffc1 linter/plugins: Implement `SourceCode#getTokenBefore()` (oxc-project#15956) (Arsh) - 776e473 linter/plugins: Implement `SourceCode#getTokensBefore()` (oxc-project#15955) (Arsh) - 595867a oxlint: Generate markdownDescription fields for oxlint JSON schema. (oxc-project#15959) (connorshea) - 5569317 vscode: Add quick actions to status bar tooltip (oxc-project#15962) (Sysix) - 986cac1 linter/plugins: Token-related `SourceCode` APIs (TS ESLint implementation) (oxc-project#15861) (Arsh) - a21f9e4 linter: Implement unicorn/prefer-bigint-literals rule (oxc-project#15923) (Michiel Vrins) - 4b9d8d2 linter/type-aware: Include range with tsconfig diagnostics (oxc-project#15916) (camc314) - 220d01e editor: Improve the status bar item for the VS Code extension by adding a tooltip. (oxc-project#15819) (connorshea) ### 🐛 Bug Fixes - 2bd3cb6 apps, editors, napi: Fix `oxlint-disable` comments (oxc-project#16014) (overlookmotel) - 81f5360 linter/prefer-number-properties: Get fixer to replace entire call expr (oxc-project#15979) (camc314) - e4ba07f language_server: Always write to memory file system (oxc-project#15975) (Sysix) - a8a2032 linter: Support missing `range` for internal diagnostics (oxc-project#15964) (camc314) - 619a226 oxlint/lsp: Don't register `textDocument/formatting` capability (oxc-project#15882) (Sysix) - 6ab1a20 linter: Fix no_useless_spread producing invalid syntax when removing empty object spreads (oxc-project#15905) (camc314) - be4b6df linter: Unicorn/prefer-string-replace-all incorrectly escapes backslashes (oxc-project#15901) (camc314) - 9fa9ef2 linter: Gracefully fail when using import plugin, large file counf and JS plugins (oxc-project#15864) (camc314) - c027398 linter/plugins: Correct bindings package names glob in TSDown config (oxc-project#15871) (overlookmotel) - b622ef8 linter: Fix `oxc/bad_array_method_on_arguments` rule behavior. (oxc-project#15854) (connorshea) - aa06c3f linter: Recognize NewExpression as value context in no-unused-private-class-members (oxc-project#15843) (camc314) - e89c5ba typescript/prefer-namespace-keyword: Skip nested `TSModuleDeclaration`s (oxc-project#15806) (overlookmotel) - 646d020 linter/exhaustive-dependencies: Prevent is_callee_of_call_expr flag from leaking into nested expressions (oxc-project#15832) (camc314) - 46bd6bd linter/plugins: Pin `@typescript-eslint/scope-manager` dependency (oxc-project#15807) (overlookmotel) - fba31fa linter: Patch `@typescript-eslint/scope manager` (oxc-project#15214) (Arsh) - 50307c1 linter/jest: Ignore `expect` identifier in argument position (oxc-project#15785) (camc314) ### ⚡ Performance - 024b48a linter/plugins: Lazy-load tokens parsing code (oxc-project#16011) (overlookmotel) - 15365c9 linter/plugins: Reduce var assignments (oxc-project#15953) (overlookmotel) - 84d1f4f linter/plugins: Downgrade some checks to debug-only (oxc-project#15922) (overlookmotel) - a49f704 linter/typescript: Avoid searching source text unless required (oxc-project#15805) (overlookmotel) ### 📚 Documentation - ceffa5a linter: Add config option docs for various rules. (oxc-project#16024) (connorshea) - 9a0ed13 linter: Fix config option docs for eslint/operator-assignment rule. (oxc-project#16030) (connorshea) - 0b18005 linter: Add config docs generation for rules with Regex arguments (oxc-project#15978) (connorshea) - 48d18e0 linter: Improve diagnostic message for promise/catch-or-return rule (oxc-project#15980) (connorshea) - 6c72e84 linter: Use backticks for code elements across more rule diagnostics (oxc-project#15958) (connorshea) - a63dad7 linter/plugins: Add comment (oxc-project#15952) (overlookmotel) - 81ea642 vscode: Use markdownDescription for better formatting in VSCode Settings (oxc-project#15889) (connorshea) - db6a110 linter/plugins: Fix JSDoc comment (oxc-project#15884) (overlookmotel) - 1487271 linter: Add config option docs for `jsdoc/require-param` and `jsdoc/require-returns` rules (oxc-project#15857) (connorshea) - fbf0fd4 linter/plugins: Add JSDoc comments to `Plugin` and `Rule` types (oxc-project#15815) (overlookmotel) - ac5e4b5 linter/plugins: Add JSDoc comments and improve comments (oxc-project#15814) (overlookmotel) - 9b7b083 linter: Fix error in `curly` `"all"` example (oxc-project#15801) (camc314) - 65a3520 linter: Improve diagnostic for consistent-type-definitions rule. (oxc-project#15752) (connorshea) ### 🛡️ Security - f9b9276 deps: Update dependency rolldown to v1.0.0-beta.51 (oxc-project#15856) (renovate[bot]) # Oxfmt ### 💥 BREAKING CHANGES - a937890 formatter: [**BREAKING**] Default to `lineWidth: 100` (oxc-project#15933) (leaysgur) - 03d5f5a formatter/sort-imports: [**BREAKING**] Change default order to `natural` with `natord` crate (oxc-project#15828) (leaysgur) - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (oxc-project#15712) (overlookmotel) ### 🚀 Features - 7818e22 formatter/sort-imports: Support `options.groups` (oxc-project#15831) (leaysgur) - f9a502c oxfmt: `oxfmt --lsp` support (oxc-project#15765) (leaysgur) ### 🐛 Bug Fixes - 4817486 formatter: Revert `FormatElement::BestFitting` printing logic (oxc-project#16028) (Dunqing) - 5562dd6 formatter: Incorrect formatting method chain with trailing comments (oxc-project#16027) (Dunqing) - 6d14c8b formatter: Comments in export class decorators are printing incorrectly (oxc-project#15897) (Dunqing) - 683c764 formatter: Correct a few minor mismatched typescript tests (oxc-project#15894) (Dunqing) - c11cc07 formatter: Improve formatting for default type on type parameters (oxc-project#15893) (Dunqing) - 0bff596 formatter: Handle JSX expresssion dangling comment (oxc-project#15890) (leaysgur) - 16a9dc8 formatter: Inconsistent printing of class extends and interface extends (oxc-project#15892) (Dunqing) - 300b496 formatter: Inconsistent CallExpression and NewExpression around member chain and logical expression (oxc-project#15858) (Dunqing) ### ⚡ Performance - 65174cc formatter: Reduce the size of `TextWidth` to 4 byte (oxc-project#15827) (Dunqing) - 4fe3aac formatter: Use `ArenaVec` and `ArenaBox` (oxc-project#15420) (Dunqing) Co-authored-by: overlookmotel <557937+overlookmotel@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 21, 2025 04:24

leaysgur requested a review from Dunqing as a code owner November 21, 2025 04:24

github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Nov 21, 2025

Copilot started reviewing on behalf of leaysgur November 21, 2025 04:24 View session

Copilot finished reviewing on behalf of leaysgur November 21, 2025 04:26

Copilot AI reviewed Nov 21, 2025

View reviewed changes

leaysgur force-pushed the 11-21-feat_formatter_default_linewidth_100 branch 2 times, most recently from 391e571 to 4fd71ed Compare November 21, 2025 04:49

graphite-app bot reviewed Nov 21, 2025

View reviewed changes

crates/oxc_formatter/tests/fixtures/mod.rs Show resolved Hide resolved

crates/oxc_formatter/tests/fixtures/mod.rs Show resolved Hide resolved

leaysgur mentioned this pull request Nov 21, 2025

test(formatter): Test default printWidth as well #15934

Merged

leaysgur changed the title ~~feat(formatter)!: Default lineWidth: 100~~ feat(formatter)!: Default to lineWidth: 100 Nov 21, 2025

leaysgur assigned Dunqing Nov 21, 2025

Dunqing approved these changes Nov 21, 2025

View reviewed changes

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 21, 2025

feat(formatter)!: Default to lineWidth: 100 (#15933)

a937890

Fixes #15900 - Update default 80 > 100 - Set `printWidth: 80` for fixture tests - Test diffs are all just adding header part for used options - Also use `printWidth: 80` for `prettier_conformance`

graphite-app bot force-pushed the 11-21-feat_formatter_default_linewidth_100 branch from 4fd71ed to a937890 Compare November 21, 2025 07:02

graphite-app bot pushed a commit that referenced this pull request Nov 21, 2025

test(formatter): Test default printWidth as well (#15934)

efbaefd

Follow up #15933 - Also tests with default `printWidth` - Refactored options printing for snapshot

graphite-app bot merged commit a937890 into main Nov 21, 2025
20 checks passed

graphite-app bot deleted the 11-21-feat_formatter_default_linewidth_100 branch November 21, 2025 07:08

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 21, 2025

leaysgur mentioned this pull request Nov 21, 2025

oxfmt: default print width from 80 to 100 #15900

Closed

Copilot AI pushed a commit that referenced this pull request Nov 21, 2025

test(formatter): Test default printWidth as well (#15934)

80fc4b0

Follow up #15933 - Also tests with default `printWidth` - Refactored options printing for snapshot

This was referenced Nov 24, 2025

release(apps): oxlint v1.30.0 && oxfmt v0.15.0 #16039

Closed

release(apps): oxlint v1.30.0 && oxfmt v0.15.0 #16047

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(formatter)!: Default to `lineWidth: 100` #15933

feat(formatter)!: Default to `lineWidth: 100` #15933

Uh oh!

leaysgur commented Nov 21, 2025 •

edited

Loading

Uh oh!

leaysgur commented Nov 21, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq bot commented Nov 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Nov 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(formatter)!: Default to lineWidth: 100 #15933

feat(formatter)!: Default to lineWidth: 100 #15933

Uh oh!

Conversation

leaysgur commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaysgur commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

codspeed-hq bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #15933 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(formatter)!: Default to `lineWidth: 100` #15933

feat(formatter)!: Default to `lineWidth: 100` #15933

leaysgur commented Nov 21, 2025 •

edited

Loading

leaysgur commented Nov 21, 2025 •

edited

Loading

codspeed-hq bot commented Nov 21, 2025 •

edited

Loading

graphite-app bot commented Nov 21, 2025 •

edited

Loading