Skip to content

docs(linter/plugins): add comment #15952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 21, 2025
Merged

docs(linter/plugins): add comment #15952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/oxlint/src-js/plugins/tokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ export function getTokens(
let nodeTokens: Token[] | null = null;
if (includeComments) {
if (tokensWithComments === null) {
// TODO: `tokens` and `comments` are already sorted, so there's a more efficient algorithm to merge them.
// That'd certainly be faster in Rust, but maybe here it's faster to leave it to JS engine to sort them?
// TODO: Once we have our own tokens which have `start` and `end` properties, we can use them instead of `range`.
tokensWithComments = [...tokens, ...comments].sort((a, b) => a.range[0] - b.range[0]);
}
nodeTokens = tokensWithComments;
Expand Down
Loading