From d76f34b1300069adc8def5f9fd1b21e05f78092d Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Sun, 23 Jun 2024 08:45:28 +0000
Subject: [PATCH] fix(transformer): TODO comments for missing scopes (#3837)

Where we create new block statements, need to generate scopes for them. Just adding TODO comments for this at present - we need an API to make this easy.
---
 crates/oxc_transformer/src/typescript/annotations.rs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/crates/oxc_transformer/src/typescript/annotations.rs b/crates/oxc_transformer/src/typescript/annotations.rs
index b1d47409bcdc7..306bd93f1ae4e 100644
--- a/crates/oxc_transformer/src/typescript/annotations.rs
+++ b/crates/oxc_transformer/src/typescript/annotations.rs
@@ -369,6 +369,7 @@ impl<'a> TypeScriptAnnotations<'a> {
         if !self.assignments.is_empty() {
             if let Statement::ExpressionStatement(expr) = &stmt.consequent {
                 if expr.expression.is_super_call_expression() {
+                    // TODO: Need to create a scope for this block
                     stmt.consequent = self.ctx.ast.block_statement(self.ctx.ast.block(
                         expr.span,
                         self.ctx.ast.new_vec_single(self.ctx.ast.copy(&stmt.consequent)),
@@ -386,6 +387,7 @@ impl<'a> TypeScriptAnnotations<'a> {
             };
             if let Some(span) = alternate_span {
                 let alternate = stmt.alternate.take().unwrap();
+                // TODO: Need to create a scope for this block
                 stmt.alternate = Some(self.ctx.ast.block_statement(
                     self.ctx.ast.block(span, self.ctx.ast.new_vec_single(alternate)),
                 ));
@@ -393,6 +395,7 @@ impl<'a> TypeScriptAnnotations<'a> {
         }
 
         if stmt.consequent.is_typescript_syntax() {
+            // TODO: Need to create a scope for this block
             stmt.consequent = self.ctx.ast.block_statement(
                 self.ctx.ast.block(stmt.consequent.span(), self.ctx.ast.new_vec()),
             );
@@ -405,6 +408,7 @@ impl<'a> TypeScriptAnnotations<'a> {
 
     pub fn transform_for_statement(&mut self, stmt: &mut ForStatement<'a>) {
         if stmt.body.is_typescript_syntax() {
+            // TODO: Need to create a scope for this block
             stmt.body = self
                 .ctx
                 .ast
@@ -414,6 +418,7 @@ impl<'a> TypeScriptAnnotations<'a> {
 
     pub fn transform_while_statement(&mut self, stmt: &mut WhileStatement<'a>) {
         if stmt.body.is_typescript_syntax() {
+            // TODO: Need to create a scope for this block
             stmt.body = self
                 .ctx
                 .ast
@@ -423,6 +428,7 @@ impl<'a> TypeScriptAnnotations<'a> {
 
     pub fn transform_do_while_statement(&mut self, stmt: &mut DoWhileStatement<'a>) {
         if stmt.body.is_typescript_syntax() {
+            // TODO: Need to create a scope for this block
             stmt.body = self
                 .ctx
                 .ast