diff --git a/app/forms/silo-create.tsx b/app/forms/silo-create.tsx index 3e4331bdac..610818dd19 100644 --- a/app/forms/silo-create.tsx +++ b/app/forms/silo-create.tsx @@ -10,6 +10,7 @@ import { NameField, RadioField, SideModalForm, + TextField, } from 'app/components/form' import { useToast } from 'app/hooks' import { pb } from 'app/util/path-builder' @@ -19,6 +20,7 @@ const defaultValues: SiloCreate = { description: '', discoverable: true, identityMode: 'saml_jit', + adminGroupName: '', } export function CreateSiloSideModalForm() { @@ -47,11 +49,7 @@ export function CreateSiloSideModalForm() { title="Create silo" formOptions={{ defaultValues }} onDismiss={onDismiss} - onSubmit={({ name, description, discoverable, identityMode }) => - createSilo.mutate({ - body: { name, description, discoverable, identityMode }, - }) - } + onSubmit={(body) => createSilo.mutate({ body })} loading={createSilo.isLoading} submitError={createSilo.error} > @@ -72,6 +70,12 @@ export function CreateSiloSideModalForm() { { value: 'local_only', label: 'Local only' }, ]} /> + )} diff --git a/app/pages/__tests__/silos.e2e.ts b/app/pages/__tests__/silos.e2e.ts index 87a69bdaa9..153b886ac4 100644 --- a/app/pages/__tests__/silos.e2e.ts +++ b/app/pages/__tests__/silos.e2e.ts @@ -23,6 +23,7 @@ test('Silos page', async ({ page }) => { await expect(page.locator('role=checkbox[name="Discoverable"]')).toBeChecked() await page.click('role=checkbox[name="Discoverable"]') await page.click('role=radio[name="Local only"]') + await page.fill('role=textbox[name="Admin group name"]', 'admins') await page.click('role=button[name="Create silo"]') // it's there in the table diff --git a/package-lock.json b/package-lock.json index 4cef548b14..4c16bd026c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7413,9 +7413,9 @@ "integrity": "sha512-ceOhN1DL7Y4O6M0j9ICgmTYziV89WMd96SvSl0REd8PMgrY0B/WBOPoed5S1KUmJqXgUXh8gzSe6E3ae27upsQ==" }, "node_modules/caniuse-lite": { - "version": "1.0.30001426", - "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001426.tgz", - "integrity": "sha512-n7cosrHLl8AWt0wwZw/PJZgUg3lV0gk9LMI7ikGJwhyhgsd2Nb65vKvmSexCqq/J7rbH3mFG6yZZiPR5dLPW5A==", + "version": "1.0.30001481", + "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001481.tgz", + "integrity": "sha512-KCqHwRnaa1InZBtqXzP98LPg0ajCVujMKjqKDhZEthIpAsJl/YEIa3YvXjGXPVqzZVguccuu7ga9KOE1J9rKPQ==", "dev": true, "funding": [ { @@ -7425,6 +7425,10 @@ { "type": "tidelift", "url": "https://tidelift.com/funding/github/npm/caniuse-lite" + }, + { + "type": "github", + "url": "https://github.com/sponsors/ai" } ] }, @@ -26085,9 +26089,9 @@ "integrity": "sha512-ceOhN1DL7Y4O6M0j9ICgmTYziV89WMd96SvSl0REd8PMgrY0B/WBOPoed5S1KUmJqXgUXh8gzSe6E3ae27upsQ==" }, "caniuse-lite": { - "version": "1.0.30001426", - "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001426.tgz", - "integrity": "sha512-n7cosrHLl8AWt0wwZw/PJZgUg3lV0gk9LMI7ikGJwhyhgsd2Nb65vKvmSexCqq/J7rbH3mFG6yZZiPR5dLPW5A==", + "version": "1.0.30001481", + "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001481.tgz", + "integrity": "sha512-KCqHwRnaa1InZBtqXzP98LPg0ajCVujMKjqKDhZEthIpAsJl/YEIa3YvXjGXPVqzZVguccuu7ga9KOE1J9rKPQ==", "dev": true }, "capital-case": {