From 5256a85bf412098e49812ab17965d9f97122f891 Mon Sep 17 00:00:00 2001
From: Benjamin Leonard <hello@benleonard.co.uk>
Date: Mon, 15 Jan 2024 17:07:47 +0000
Subject: [PATCH 1/5] Improve clickability of link cells

---
 libs/table/cells/LinkCell.tsx | 12 +++++++++---
 libs/ui/lib/table/Table.tsx   |  2 +-
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/libs/table/cells/LinkCell.tsx b/libs/table/cells/LinkCell.tsx
index 5a79ea2494..3c689e2cff 100644
--- a/libs/table/cells/LinkCell.tsx
+++ b/libs/table/cells/LinkCell.tsx
@@ -13,8 +13,14 @@ export const linkCell =
   (makeHref: (value: string) => string) =>
   ({ value }: Cell<string>) => {
     return (
-      <Link className="text-sans-semi-md text-default hover:underline" to={makeHref(value)}>
-        {value}
-      </Link>
+      <>
+        <Link
+          className="link-cell absolute inset-0 flex h-full w-full"
+          to={makeHref(value)}
+        />
+        <span className="text-sans-semi-md text-default group-hover/cell:underline">
+          {value}
+        </span>
+      </>
     )
   }
diff --git a/libs/ui/lib/table/Table.tsx b/libs/ui/lib/table/Table.tsx
index 1471922999..27e6848f6d 100644
--- a/libs/ui/lib/table/Table.tsx
+++ b/libs/ui/lib/table/Table.tsx
@@ -112,7 +112,7 @@ Table.Cell = ({ height = 'large', className, children, ...props }: TableCellProp
     >
       <div
         className={cn(
-          '-my-[1px] -mr-[2px] flex items-center border-b border-l py-3 pl-3 pr-3 border-secondary',
+          'group/cell -my-[1px] -mr-[2px] flex items-center border-b border-l py-3 pl-3 pr-3 border-secondary',
           heightClass
         )}
       >

From ef936ab35090fb4a32d0f0bfcc61f349f92d8a5e Mon Sep 17 00:00:00 2001
From: Benjamin Leonard <hello@benleonard.co.uk>
Date: Mon, 15 Jan 2024 17:12:11 +0000
Subject: [PATCH 2/5] Simplify with `peer`

---
 libs/table/cells/LinkCell.tsx | 9 ++-------
 libs/ui/lib/table/Table.tsx   | 2 +-
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/libs/table/cells/LinkCell.tsx b/libs/table/cells/LinkCell.tsx
index 3c689e2cff..3ae59b56ca 100644
--- a/libs/table/cells/LinkCell.tsx
+++ b/libs/table/cells/LinkCell.tsx
@@ -14,13 +14,8 @@ export const linkCell =
   ({ value }: Cell<string>) => {
     return (
       <>
-        <Link
-          className="link-cell absolute inset-0 flex h-full w-full"
-          to={makeHref(value)}
-        />
-        <span className="text-sans-semi-md text-default group-hover/cell:underline">
-          {value}
-        </span>
+        <Link className="peer absolute inset-0 flex h-full w-full" to={makeHref(value)} />
+        <span className="text-sans-semi-md text-default peer-hover:underline">{value}</span>
       </>
     )
   }
diff --git a/libs/ui/lib/table/Table.tsx b/libs/ui/lib/table/Table.tsx
index 27e6848f6d..1471922999 100644
--- a/libs/ui/lib/table/Table.tsx
+++ b/libs/ui/lib/table/Table.tsx
@@ -112,7 +112,7 @@ Table.Cell = ({ height = 'large', className, children, ...props }: TableCellProp
     >
       <div
         className={cn(
-          'group/cell -my-[1px] -mr-[2px] flex items-center border-b border-l py-3 pl-3 pr-3 border-secondary',
+          '-my-[1px] -mr-[2px] flex items-center border-b border-l py-3 pl-3 pr-3 border-secondary',
           heightClass
         )}
       >

From 6b43a74aa7b15f75e0cc3149915f390de55d74f6 Mon Sep 17 00:00:00 2001
From: Benjamin Leonard <hello@benleonard.co.uk>
Date: Tue, 16 Jan 2024 12:40:47 +0000
Subject: [PATCH 3/5] Try alternate method (keeps text in the link)

---
 libs/table/cells/LinkCell.tsx | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/libs/table/cells/LinkCell.tsx b/libs/table/cells/LinkCell.tsx
index 3ae59b56ca..a295bcf7e9 100644
--- a/libs/table/cells/LinkCell.tsx
+++ b/libs/table/cells/LinkCell.tsx
@@ -13,9 +13,14 @@ export const linkCell =
   (makeHref: (value: string) => string) =>
   ({ value }: Cell<string>) => {
     return (
-      <>
-        <Link className="peer absolute inset-0 flex h-full w-full" to={makeHref(value)} />
-        <span className="text-sans-semi-md text-default peer-hover:underline">{value}</span>
-      </>
+      <Link
+        className="flex h-full w-full items-center text-sans-semi-md text-default hover:underline"
+        aria-label={value}
+        to={makeHref(value)}
+      >
+        {value}
+
+        <div className="absolute inset-0" />
+      </Link>
     )
   }

From c2c0549b72f7e23ebb353c7b30b0d7e51d9a8e09 Mon Sep 17 00:00:00 2001
From: Benjamin Leonard <hello@benleonard.co.uk>
Date: Mon, 22 Jan 2024 11:46:46 +0000
Subject: [PATCH 4/5] Remove `aria-label`

---
 libs/table/cells/LinkCell.tsx | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libs/table/cells/LinkCell.tsx b/libs/table/cells/LinkCell.tsx
index a295bcf7e9..d206da1c2b 100644
--- a/libs/table/cells/LinkCell.tsx
+++ b/libs/table/cells/LinkCell.tsx
@@ -15,11 +15,9 @@ export const linkCell =
     return (
       <Link
         className="flex h-full w-full items-center text-sans-semi-md text-default hover:underline"
-        aria-label={value}
         to={makeHref(value)}
       >
         {value}
-
         <div className="absolute inset-0" />
       </Link>
     )

From 999774c0108d55de45eb6e75f3cef262f89e8924 Mon Sep 17 00:00:00 2001
From: Benjamin Leonard <hello@benleonard.co.uk>
Date: Mon, 22 Jan 2024 11:48:06 +0000
Subject: [PATCH 5/5] Comment

---
 libs/table/cells/LinkCell.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libs/table/cells/LinkCell.tsx b/libs/table/cells/LinkCell.tsx
index d206da1c2b..5cfa6be5a9 100644
--- a/libs/table/cells/LinkCell.tsx
+++ b/libs/table/cells/LinkCell.tsx
@@ -18,6 +18,7 @@ export const linkCell =
         to={makeHref(value)}
       >
         {value}
+        {/* Pushes out the link area to the entire cell for improved clickability™ */}
         <div className="absolute inset-0" />
       </Link>
     )