diff --git a/app/components/Pagination.tsx b/app/components/Pagination.tsx index 3a09c77bc3..f164208fb1 100644 --- a/app/components/Pagination.tsx +++ b/app/components/Pagination.tsx @@ -14,13 +14,7 @@ import { const Tunnel = tunnel('pagination') -interface PaginationProps extends UIPaginationProps { - /** If true pagination will be rendered wherever `Pagination.Target` is included */ - inline?: boolean -} -export function Pagination({ inline = false, ...props }: PaginationProps) { - if (inline) return - +export function Pagination(props: UIPaginationProps) { return ( diff --git a/app/layouts/helpers.tsx b/app/layouts/helpers.tsx index fc6173bd2b..64a00c9cb0 100644 --- a/app/layouts/helpers.tsx +++ b/app/layouts/helpers.tsx @@ -27,7 +27,7 @@ export function ContentPane() { -
+
diff --git a/app/table/QueryTable.tsx b/app/table/QueryTable.tsx index f4906c3d80..4c78da2cef 100644 --- a/app/table/QueryTable.tsx +++ b/app/table/QueryTable.tsx @@ -53,8 +53,6 @@ export const useQueryTable = ( type QueryTableProps = { /** Prints table data in the console when enabled */ debug?: boolean - /** Function that produces a list of actions from a row item */ - pagination?: 'inline' | 'page' pageSize?: number rowHeight?: 'small' | 'large' emptyState: React.ReactElement @@ -71,7 +69,6 @@ const makeQueryTable = >( ): ComponentType> => function QueryTable({ debug, - pagination = 'page', pageSize = PAGE_SIZE, rowHeight = 'small', emptyState, @@ -115,7 +112,6 @@ const makeQueryTable = >( <> { } export interface PaginationProps { - type?: 'inline' | 'page' pageSize: number hasNext: boolean hasPrev: boolean @@ -37,7 +36,6 @@ export interface PaginationProps { className?: string } export const Pagination = ({ - type = 'inline', pageSize, hasNext, hasPrev, @@ -50,7 +48,6 @@ export const Pagination = ({ <>
{ const row = page.getByRole('row', { name: 'disk-1-snapshot-6' }) + // scroll a little so the dropdown menu isn't behind the pagination bar + await page.getByRole('table').click() // focus the content pane + await page.mouse.wheel(0, 200) + async function clickDelete() { await row.getByRole('button', { name: 'Row actions' }).click() await page.getByRole('menuitem', { name: 'Delete' }).click()