8496 issue

Author: smklein

nexus/reconfigurator/execution/src/omicron_zones.rs

@@ -168,6 +168,9 @@ async fn oximeter_cleanup(
     Ok(())
 }
 
+// TODO(https://github.com/oxidecomputer/omicron/issues/8496): If this service
+// was fully in DNS, this would not be necessary.
+//
 // Helper trait that is implemented by `Resolver`, but allows unit tests to
 // inject a fake resolver that points to a mock server when calling
 // `decommission_cockroachdb_node()`.

nexus/src/app/background/tasks/crdb_node_id_collector.rs

@@ -128,6 +128,9 @@ impl CockroachNodeIdCollector {
 // This trait exists so we can inject addresses in our unit tests below that
 // aren't required to have admin servers listening on the fixed
 // `COCKROACH_ADMIN_PORT`.
+//
+// TODO(https://github.com/oxidecomputer/omicron/issues/8496): Add the admin
+// service to DNS, remove this?
 trait CockroachAdminFromBlueprint {
     fn cockroach_admin_addrs<'a>(
         &'a self,

nexus/src/app/background/tasks/inventory_collection.rs

@@ -199,7 +199,9 @@ async fn inventory_activate(
         .await
         .context("looking up cockroach addresses")?;
 
-    // TODO: Allow a hard-coded option to find the admin interface here.
+    // TODO(https://github.com/oxidecomputer/omicron/issues/8496): If
+    // we could look up the admin service, instead of hard-coding it as
+    // "same as cockroach, but different port", that be preferable.
     let admin_addresses: Vec<_> = cockroach_addresses
         .into_iter()
         .map(|mut addr| {