authz initialization messages should be "info" level #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
approved these changes
Jun 24, 2022
leftwo
pushed a commit
that referenced
this pull request
Apr 30, 2024
Propolis: Update oximeter dependency to pull in automatic producer registration (#689) Propagate ReplaceResult up; return disk status (#687) Enable clippy warnings for lossless casts Update rustls deps for CVE-2024-32650 migration: refrain from offering all pages when possible (#682) Crucible: DTrace probes for IO on/off the network (#1284) Update oximeter dep to pull in automatic producer registration (#1279) Remove `ReadResponse` in favor of `RawReadResponse` (#1212) Fix typo in DTrace upstairs_info (#1276) replace needing no work should not be an error (#1275) Add some DTrace scripts to the package. (#1274) More Pantry updates for Region replacement (#1269) Send the correct task count for reconciliations (#1271) Raw extent cleanup (#1268)
leftwo
added a commit
that referenced
this pull request
Apr 30, 2024
Propolis: Update oximeter dependency to pull in automatic producer registration (#689) Propagate ReplaceResult up; return disk status (#687) Enable clippy warnings for lossless casts Update rustls deps for CVE-2024-32650 migration: refrain from offering all pages when possible (#682) Crucible: DTrace probes for IO on/off the network (#1284) Update oximeter dep to pull in automatic producer registration (#1279) Remove `ReadResponse` in favor of `RawReadResponse` (#1212) Fix typo in DTrace upstairs_info (#1276) replace needing no work should not be an error (#1275) Add some DTrace scripts to the package. (#1274) More Pantry updates for Region replacement (#1269) Send the correct task count for reconciliations (#1271) Raw extent cleanup (#1268) --------- Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authz subsystem emits a bunch of log messages during startup at the "trace" level. I think they should be "info" level. There's a constant number of them and it's only at startup time so it's not like this should have a big impact on runtime behavior. And they're very helpful for getting the ground truth on what Oso policy and environment is set up, which is helpful for authz debugging.
Note one of these messages dumps out the whole Oso policy, which is huge. Maybe people will find this annoying? But it's part of what's really helpful to have and I think will be helpful in production if we have unexpected authz issues.