Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See oxidecomputer/garbage-compactor#5. This change uses that new build in Omicron. This updates to CockroachDB v22.1.9 using Go 1.17.13. It also makes it a "stdmalloc" build, meaning it uses the system memory allocator rather than the default jemalloc. It also means we can override this to use libumem at runtime if we want.
We're still seeing issues like #1223 -- see #1223 (comment). If the problem is not worse, I'd like to proceed anyway (since we were seeing these issues before). I can't yet tell if it's worse. (Another option would be to land this if it seems at least not totally broken, and then revert if folks run into more frequent problems.)