[31/n] [reconfigurator-cli] add inventory-show command #8617
+428
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
jgallagher
reviewed
Jul 17, 2025
Comment on lines
1405
to
1414
| ORPHANED DATASETS | ||
|
|
||
| sled 2eb69596-f081-4e2d-9425-9994926e0832 (serial serial1) | ||
| no orphaned datasets | ||
|
|
||
| sled 32d8d836-4d8a-4e54-8fa9-f31d79c42646 (serial serial2) | ||
| no orphaned datasets | ||
|
|
||
| sled 89d02b1b-478c-401a-8e28-7a26f74fa41b (serial serial0) | ||
| no orphaned datasets |
Contributor
There was a problem hiding this comment.
(This comment is about #8613 but is easier to show here.)
This is the section I think we don't want by default, since this is already reported inside the ledgered config results of each sled above. But we want to be able to ask for this section on its own, so we have a quick way to check for orphans.
jgallagher
reviewed
Jul 17, 2025
| " found at: {} from {}", | ||
| sled.time_collected, sled.source | ||
| sled.time_collected | ||
| .to_rfc3339_opts(SecondsFormat::Millis, /* use_z */ true), |
Contributor
There was a problem hiding this comment.
Hah, I had made this exact same change before realizing it wasn't enough and filing #8611 👍
jgallagher
approved these changes
Jul 17, 2025
sunshowers
changed the base branch from
sunshowers/spr/main.31n-reconfigurator-cli-add-inventory-show-command
to
main
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/31n-reconfigurator-cli-add-inventory-show-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the display logic implemented in #8613 to show inventory collections in reconfigurator-cli.
I had to change some of the timestamps to be in RFC 3339 format to allow redactions to work properly.
Depends on:
Kind of addresses #8611, in the sense that we now have tests that render collection output and ensure it looks reasonable.