test-utils: surface dpd errors. #9379
Merged
+50
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
love it — deleted 
|
Contributor
|
The test failure looks like this flake: #9041 |
david-crespo
approved these changes
Nov 10, 2025
At the moment, DendriteInstance::start in omicron-test-utils doesn't catch errors in dpd. We spawn a child process, wait up to the timeout interval to discover the dpd port from its logs, and fail if we can't discover the port. But if dpd exits quickly, we still wait the timeout interval and swallow any errors. This patch captures the stderr of the dpd child process, checks it for an early exit, and prints the details if dpd crashes.
jmcarp
force-pushed
the
jmcarp/test-utils-catch-dpd-errors
branch
from
3c4f92e to
0b3f3b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, DendriteInstance::start in omicron-test-utils doesn't catch errors in dpd. We spawn a child process, wait up to the timeout interval to discover the dpd port from its logs, and fail if we can't discover the port. But if dpd exits quickly, we still wait the timeout interval and swallow any errors. This patch captures the stderr of the dpd child process, checks it for an early exit, and prints the details if dpd crashes.
This was bugging me when I was having trouble getting simulated omicron to start due to my PATH pointing to the wrong dpd executable. h/t @david-crespo.