Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle quote characters in customer fields #18

Closed
iugo-josh opened this issue Mar 1, 2017 · 3 comments
Closed

Handle quote characters in customer fields #18

iugo-josh opened this issue Mar 1, 2017 · 3 comments
Assignees
@iugo-josh

Comments

@iugo-josh
Copy link
Contributor

Customer fields are sent to Oxipay through a hidden form in the checkout. The customer values are not being escaped in the output of this form, so quote characters break the HTML:

field_escaping
@iugo-josh iugo-josh self-assigned this Mar 7, 2017
iugo-josh added a commit that referenced this issue Mar 14, 2017
@iugo-josh
Update checkout form as details are updated
042f4f8 
Changed the hidden form from being generated on the server side to
be generated on the client side instead. Added event listeners to
update the form as user details are modified.

Added scope settings to allow branding configuration to be changed
at the store level. Updated front end code to request data in the
correct scope.

Changes should fix issues #10, #17, #18 and #22.
@iugo-josh iugo-josh mentioned this issue Mar 14, 2017
Closed
@sam-flexi
Copy link
Collaborator

To work out whether more QA work is needed or we can hand over to Esteban.

@sam-flexi
Copy link
Collaborator

Sam to have a quick look and confirm issue resolved.

@esteban-terem
Copy link
Contributor

Hi. This is resolved in the new plugin implementation (since revision 196b1f8, branch develop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iugo-josh iugo-josh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iugo-josh @sam-flexi @esteban-terem