Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping/Billing Country other than AU and NZ being accepted #8

Closed
MattBlair01 opened this issue Jan 23, 2017 · 4 comments
Closed

Shipping/Billing Country other than AU and NZ being accepted #8

MattBlair01 opened this issue Jan 23, 2017 · 4 comments
Assignees

Comments

@MattBlair01
Copy link
Collaborator

MattBlair01 commented Jan 23, 2017

image

image

The service is accepting Countries outside AU and NZ.
Oxipay should only be a payment option in these countries, and return a message similar to the attached.

@sam-flexi
Copy link
Collaborator

Hi,

Issue is still occuring, here I was able to type in an address in France however I was able to proceed with payment to the Oxipay Gateway and was not blocked at the shopping cart level.

Can you please change it so that only addresses in Australia or New Zealand are allowed for Oxipay?

image

@iugo-josh iugo-josh self-assigned this Mar 15, 2017
iugo-josh added a commit that referenced this issue Mar 16, 2017
Added the "Payment from Specific Countries" field to the config,
restricted to only allow selction of AU and/or NZ. This is a
built in Magento field that hides the payment option if a country
outside of the selected values is set for shipping.
Added error checking to stop orders from outside the selected
countries. This is primarily for billing address, but also checks
the shipping country in the cases where the magento logic fails.
Improved error checking functionality and error display in the
checkout.

Fixes issue #8
@sam-flexi
Copy link
Collaborator

sam-flexi commented Mar 20, 2017

There's a few issues with the current fix:

1 - If a user selects a country other than AU/NZ then Oxipay will not be displayed as a payment option.

2 - The only way to trigger the display of the error message is to put in AU/NZ as country in the checkout screen, select Oxipay as payment option and then edit either the shipping or billing address and put in a country other than AU/NZ.

3 - Oxipay will not be displayed as a payment option if the user types in a country other than AU/NZ (such as USA). However, if the user then edit this address and changes the country back to AU/NZ then Oxipay will still not be displayed as a payment option.

4 - The error message is not static - i.e. it disappears after about 5 seconds or when the user interacts with the page.

We would like to change this so that:

1 - Oxipay is always visible as a payment option regardless of the country that the user types in.

2 - If the country is AU/NZ then no error message is displayed and user can progress to the Oxipay site.

3 - If the country is not AU/NZ then the error message is displayed.

4- The error message that gets displayed needs to be static and should not disappear after the user interacts with the page or after a 5 second interval as currently is the case.

iugo-josh added a commit that referenced this issue Mar 23, 2017
@iugo-josh
Copy link
Contributor

I've pushed a new commit to PR #23 to address the feedback regarding the removal of the payment option when the user selects an address outside of Australia or New Zealand.

To property test this change, you will need to delete the row from the 'core_config_data' table with the path 'payment/oxipay_gateway/allowspecific'. You will also need to clear the cache.

@sam-flexi
Copy link
Collaborator

Issue fixed in new plugin code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants