Checkout fixes #23
Closed
Checkout fixes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Sandbox URL config option. Always use Gateway URL config value.
fixes issue 6
Fixes issue 4
Addresses feedback in issue #6
Addresses feedback on issue #16
Changed the hidden form from being generated on the server side to be generated on the client side instead. Added event listeners to update the form as user details are modified. Added scope settings to allow branding configuration to be changed at the store level. Updated front end code to request data in the correct scope. Changes should fix issues #10, #17, #18 and #22.
Added the "Payment from Specific Countries" field to the config, restricted to only allow selction of AU and/or NZ. This is a built in Magento field that hides the payment option if a country outside of the selected values is set for shipping. Added error checking to stop orders from outside the selected countries. This is primarily for billing address, but also checks the shipping country in the cases where the magento logic fails. Improved error checking functionality and error display in the checkout. Fixes issue #8
|
I've added a commit to address issue #8. This adds a config field to select allowed checkout countries, so please ensure this is set before testing. The added field is a built in Magento field that has logic to hide the payment method when a shipping address outside of the selected options is chosen by the customer. This does not seem to be completely foolproof, as it is possible to make the method appear by first selecting an allowed country, then going back to the shipping step and changing the address to a different country. The commit contains additional checks that will pick this up and block the order however. |
|
Removing this from the Magento 2 board as this is a reference to a PR and not an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes should fix issues #10, #17, #18 and #22.
This PR was branched from the code in PR #21, so please complete the review of that PR first.
There is an issue with config variable scope in Magento that was fixed in version 2.1.4: magento/magento2#7943 . Please ensure your Magento install has been updated before testing.