Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename containername mega-linter-runner argument to container-name #1570

Closed
Kurt-von-Laven opened this issue Jun 28, 2022 · 2 comments · Fixed by #1571
Closed

Rename containername mega-linter-runner argument to container-name #1570

Kurt-von-Laven opened this issue Jun 28, 2022 · 2 comments · Fixed by #1571
Assignees
Labels
bug Something isn't working nostale This issue or pull request is not stale, keep it open

Comments

@Kurt-von-Laven
Copy link
Collaborator

Kurt-von-Laven commented Jun 28, 2022

Describe the bug

It seems odd to spell the argument containername when the name of the package itself is hyphenated, and containername will get flagged as a CSpell error in downstream projects that use MegaLinter (e.g., when committing a script that runs MegaLinter to their package.json or .pre-commit-config.yaml). I did the code review in which this feature was added, so apologies for not considering this sooner.

To Reproduce

Steps to reproduce the behavior:

  1. Read mega-linter-runner usage docs.

Expected behavior

I expected the argument to have a correctly spelled name.

Additional context

I considered adding "containername" to CSpell in streetsidesoftware/cspell-dicts#1207, and the maintainer understandably discouraged adding a misspelled word.

@Kurt-von-Laven Kurt-von-Laven added the bug Something isn't working label Jun 28, 2022
@Kurt-von-Laven Kurt-von-Laven self-assigned this Jun 28, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jul 29, 2022
@Kurt-von-Laven Kurt-von-Laven added nostale This issue or pull request is not stale, keep it open and removed O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity labels Jul 29, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Aug 29, 2022
@Kurt-von-Laven Kurt-von-Laven removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nostale This issue or pull request is not stale, keep it open
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant