Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle renovate version comments in build script #3617

Merged
merged 6 commits into from
Jun 8, 2024

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented Jun 5, 2024

Fixes #

Proposed Changes

  1. Consider ARG instructions lines starting with # renovate: as an ARG instruction
  2. Consider ARG instructions when separating ARG from FROM instructions.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix echoix enabled auto-merge (squash) June 7, 2024 00:39
@echoix echoix added python Pull requests that update Python code infrastructure labels Jun 7, 2024
@echoix
Copy link
Collaborator Author

echoix commented Jun 7, 2024

I'd like this to be merged before enabling renovate. It will allow to create some PRs adding version comments + build args and seeing them in the on-boarding PR.

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see :)

@echoix echoix merged commit e323983 into oxsecurity:main Jun 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants