Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add pytest-rerunfailures #3993

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

AlejandroSuero
Copy link
Contributor

Proposed Changes

  1. Added pytest-rerunfailures to dev/requirements
  2. Modify entrypoint.sh to use and install pytest-rerunfailures
  3. Added rerunfailures to .cspell.json

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix echoix merged commit f48daf1 into oxsecurity:main Sep 12, 2024
6 checks passed
@AlejandroSuero AlejandroSuero deleted the add-pytest-rerunfailures branch September 12, 2024 13:59
@nvuillam
Copy link
Member

I love this PR :)
Let's see if it has an impact on or sometimes failing for no reason pipelines ^^

@echoix
Copy link
Collaborator

echoix commented Sep 12, 2024

It went into action in the auto update PR. Puppetlint test format fix got rerun 3 times and failed. Maybe using the default 5, or waiting more than 1 second between each retry might help (we have some tests that take a long time).

But the real fix would be to have our tests non-flaky. That's just a patch

@nvuillam
Copy link
Member

@echoix as failures are often due to race conditions, indeed wait for more than one second could be relevant
I don't know how to make tests less flaky without removing the parallel testing and going back to the 1h PRs :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants