-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section on well-formedness constraints and their connection to P4Runtime to the language spec #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smolkaj
changed the title
Update language-specification.md
Add section on well-formedness constraints and their connection to P4Runtime to the language spec
Aug 5, 2023
fruffy
reviewed
Aug 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a constraint imposed by the P4Runtime standard, correct?
jonathan-dilorenzo
previously approved these changes
Aug 9, 2023
jonathan-dilorenzo
previously approved these changes
Aug 22, 2023
smolkaj
force-pushed
the
smolkaj-patch-3
branch
2 times, most recently
from
May 6, 2024 17:40
9d4234f
to
4a136a4
Compare
@jonathan-dilorenzo PTAL. FYI, we should also update the section on "metdata" in case we rename it.
jonathan-dilorenzo
previously approved these changes
May 6, 2024
jonathan-dilorenzo
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonathan-dilorenzo PTAL.
FYI, we should also update the section on "metdata" in case we rename it.