lenient treatment of garbage properties

[smolkaj]

Currently it's possible to specify arbitrary table properties, without provoking a compiler error:

   table t {
        key = { }
        actions = { }
        something = "random";
        number = 1;
    }

Is this intended behavior, to allow the backend to use these properties? If so, at the very least I would expect a warning from the backend in case it does not understand a property. I'm concerned that this will otherwise be a source of very hard-to-find bugs:

table t {
    // typo; may be hard to spot
    sizes = 1024
}

[smolkaj]

I verified that the compiler now prints a warning.

[smolkaj]

I now see a large number of warning for my translation of switch.p4:

l2.p4(142): warning: Unknown table property: support_timeout
        support_timeout = true;
        ^^^^^^^^^^^^^^^
multicast.p4(374): warning: Unknown table property: ipv4_multicast_route_star_g_stats
        @name("ipv4_multicast_route_star_g_stats") counters =
                                                   ^^^^^^^^
multicast.p4(390): warning: Unknown table property: ipv4_multicast_route_s_g_stats
        @name("ipv4_multicast_route_s_g_stats") counters =
                                                ^^^^^^^^
multicast.p4(467): warning: Unknown table property: ipv6_multicast_route_star_g_stats
        @name("ipv6_multicast_route_star_g_stats") counters =
                                                   ^^^^^^^^
multicast.p4(485): warning: Unknown table property: ipv6_multicast_route_s_g_stats
        @name("ipv6_multicast_route_s_g_stats") counters =
                                                ^^^^^^^^
meter.p4(40): warning: Unknown table property: meters
        meters = meter_index;
        ^^^^^^
meter.p4(77): warning: Unknown table property: meter_stats
        @name("meter_stats") counters =
                             ^^^^^^^^
security.p4(77): warning: Unknown table property: storm_control_stats
        @name("storm_control_stats") counters = direct_counter(CounterType.packets);
                                     ^^^^^^^^
l2.p4(279): warning: Unknown table property: egress_bd_stats
        @name("egress_bd_stats") counters =
                                 ^^^^^^^^

@mbudiu-vmw: I just wanted to check back with you and see if these properties are indeed unknown by bmv2, or if we need to update the knownProperties list.

[smolkaj]

All fixed.