Desugar valid matches correctly in p4RuntimeSerializer #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
approved these changes
Feb 18, 2017
| @@ -1372,13 +1374,14 @@ getMatchFields(const IR::P4Table* table, ReferenceMap* refMap, TypeMap* typeMap) | |||
| matchType = MatchField::TERNARY; | |||
|
|
|||
| // If this is a ternary match on the result of an isValid() call, desugar | |||
| // that to a ternary match against the '$valid$' field of the appropriate | |||
| // that to a ternary match against the '_valid' field of the appropriate | |||
There was a problem hiding this comment.
_valid would seem problematic if a user defined a header with a _valid field. It would seem better to use something that can't collide with a user name ($valid as users can't use $ in names?)
There was a problem hiding this comment.
We won't need to insert that field any more once we update p4info.proto to treat match fields differently
There was a problem hiding this comment.
Sounds like we'll be revisiting that issue shortly.
antoninbas
approved these changes
Feb 18, 2017
sethfowler
force-pushed
the
seth/desugar-valid-matches-correctly-in-p4runtimeserializer
branch
from
b44d470
to
38198fe
Compare
sethfowler
deleted the
seth/desugar-valid-matches-correctly-in-p4runtimeserializer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now p4RuntimeSerializer doesn't correctly handle the
validmatch type (orisValid()in P4-16). There were several issues:We serialized the synthesized valid field inconsistently; in one place, we used
_valid, while in the other place, we used$valid$.We didn't append the synthesized valid field when serializing exact match keys.
We appended it at the wrong time when serializing ternary match keys, which caused a crash.
All of this would've easily been avoided with a proper unit test suite. =\ I need to hurry up and add gtest to p4c.