Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit tables/actions with @hidden from p4runtime #476

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

antoninbas
Copy link
Member

No description provided.

Copy link
Contributor

@sethfowler sethfowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

There is one issue: by filtering at this stage, objects which are tagged with @hidden are still considered when generating aliases. If your program has two objects, a.b.c and @hidden d.b.c, ideally a.b.c would receive the alias c. With this patch, it will receive the alias a.b.c, as it would if d.b.c was included in the program.

I don't think this is important enough to block landing this patch, but if you don't have time to fix it now, could you please file an issue about it so we'll remember to fix it at some point?

@antoninbas
Copy link
Member Author

I opened #479. I think this becomes important if the P4 programmer becomes using @hidden. Until then, we only use it for compiler-generated objects and this issue is unlikely to arise.

@antoninbas antoninbas deleted the p4runtime-use-hidden-annotation branch April 20, 2017 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants